Oct 2021

3 commits
Remove unstable pg_amcheck tests.
14 Oct 2021Peter Geogheganmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.1
LLM analysis, 100% surewritten from the discussion, no matching patch3 of 3 reviewers saw the final version

The commit deletes all 233 lines of src/bin/pg_amcheck/t/006_bad_targets.pl without a corresponding attached removal patch. Tom Lane proposed dropping the unstable tests in #72, Peter Geoghegan agreed in #74, and confirmed the removal in #80.

  • Tom Lanesaw the final versionLLM analysis, 99% sureTom investigated the test failures and proposed removing the test file in #72, which became the committed remedy.
  • Andrew Dunstansaw the final versionLLM analysis, 94% sureAndrew reported matching failures on another Windows buildfarm animal in #69 and supported investigating separately if the test was removed in #79, both before the removal commit.
  • Mark Dilgersaw the final versionLLM analysis, 95% sureMark investigated the background_psql harness in #70 and explicitly accepted removing the tests in #77.
pg_amcheck: avoid unhelpful verification attempts.
13 Oct 2021Peter Geogheganmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #631 of 2 reviewers saw the final version

The pg_amcheck.c and t/006_bad_targets.pl changes match #63 exactly; only the documentation warning changes from Hot Standby failure to stronger locking and blocked DML. The attachment credits Mark Dilger, and #65 confirms that only the agreed documentation edits were added.

  • Peter Geoghegansaw the final versiontrailerPeter reviewed recovery filtering in #48, approved the revised approach in #61, questioned redundant temporary-relation checks in #63, and committed the final version.
  • Robert Haassaw an earlier versiontrailerRobert supported filtering unsuitable relations in #18 and rejected silently downgrading requested checks in #31, during the initial patch phase before the substantially expanded implementation was posted.
amcheck: Skip unlogged relations in Hot Standby.
12 Oct 2021Peter Geogheganmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #601 of 1 reviewer saw the final version

The commit extracts the contrib/amcheck/verify_heapam.c and verify_nbtree.c changes from #60, adding only explanatory comments about treating unlogged relations as empty. The client, documentation, and tests remain in the remainder posted at #63.

  • Peter Geoghegansaw the final versiontrailerPeter proposed consistent backend handling with DEBUG1 messages in #58, approved the revision in #61, and committed this extracted portion.

Credits across 3 commits

Author
Mark Dilger2
Reviewer
Peter Geoghegan2
Robert Haas1
Reported by
Alexander Lakhin1
Committer
Peter Geoghegan3