Remove an obsolete comment in snapbuild.c
Hi all,
While reading the code I realized that the following comment of
SnapBuildOnDick is obsolete:
/*
* We store current state of struct SnapBuild on disk in the following manner:
*
* struct SnapBuildOnDisk;
* TransactionId * running.xcnt_space;
* TransactionId * committed.xcnt; (*not xcnt_space*)
*
*/
typedef struct SnapBuildOnDisk
Since SnapBuild has no longer "running" struct, it should be removed.
Please find an attached patch.
Regards,
--
Masahiko Sawada
EDB: https://www.enterprisedb.com/
Attachments:
fix_obsolete_comment_in_snapbuild.c.patchapplication/octet-stream; name=fix_obsolete_comment_in_snapbuild.c.patchDownload
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
index a14a3d6900..a5333349a8 100644
--- a/src/backend/replication/logical/snapbuild.c
+++ b/src/backend/replication/logical/snapbuild.c
@@ -1422,7 +1422,6 @@ SnapBuildWaitSnapshot(xl_running_xacts *running, TransactionId cutoff)
* We store current state of struct SnapBuild on disk in the following manner:
*
* struct SnapBuildOnDisk;
- * TransactionId * running.xcnt_space;
* TransactionId * committed.xcnt; (*not xcnt_space*)
*
*/
On Mon, Oct 4, 2021 at 1:24 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
Hi all,
While reading the code I realized that the following comment of
SnapBuildOnDick is obsolete:/*
* We store current state of struct SnapBuild on disk in the following manner:
*
* struct SnapBuildOnDisk;
* TransactionId * running.xcnt_space;
* TransactionId * committed.xcnt; (*not xcnt_space*)
*
*/
typedef struct SnapBuildOnDiskSince SnapBuild has no longer "running" struct, it should be removed.
Please find an attached patch.
LGTM. I'll push this tomorrow unless someone thinks otherwise.
--
With Regards,
Amit Kapila.