Improved tab completion for PostgreSQL parameters in enums
Hi
If you do tab completion in a situation like A, you will see ["on"]
instead of [on].
A : "ALTER SYSTEM SET wal_compression TO "
I made a patch for this problem.
regards,
Kosei Masumura
Attachments:
enum.patchtext/x-diff; name=enum.patchDownload
diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 4155d81252..86087e790b 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -969,7 +969,7 @@ Query_for_index_of_table \
#define Query_for_enum \
" SELECT name FROM ( "\
-" SELECT pg_catalog.quote_ident(pg_catalog.unnest(enumvals)) AS name "\
+" SELECT pg_catalog.unnest(enumvals) AS name "\
" FROM pg_catalog.pg_settings "\
" WHERE pg_catalog.lower(name)=pg_catalog.lower('%s') "\
" UNION ALL " \
On Wed, Oct 06, 2021 at 02:24:40PM +0900, bt21masumurak wrote:
If you do tab completion in a situation like A, you will see ["on"] instead
of [on].A : "ALTER SYSTEM SET wal_compression TO "
I made a patch for this problem.
This would break the completion of enum entries that require quotes to
work properly for some of their values, like
default_transaction_isolation.
--
Michael
bt21masumurak <bt21masumurak@oss.nttdata.com> writes:
If you do tab completion in a situation like A, you will see ["on"]
instead of [on].
A : "ALTER SYSTEM SET wal_compression TO "
I made a patch for this problem.
I do not think this is an improvement. It will result in omitting
quotes in some cases where they're not optional. Try it with a
value such as "all", for example.
regards, tom lane
Thank you for comments.
I do not think this is an improvement. It will result in omitting
quotes in some cases where they're not optional. Try it with a
value such as "all", for example.
This would break the completion of enum entries that require quotes to
work properly for some of their values, like
default_transaction_isolation.
I understand these comments, and the proposal was withdrawn.
Regards,
Kosei Masumura
2021-10-06 23:34 に Tom Lane さんは書きました:
Show quoted text
bt21masumurak <bt21masumurak@oss.nttdata.com> writes:
If you do tab completion in a situation like A, you will see ["on"]
instead of [on].A : "ALTER SYSTEM SET wal_compression TO "
I made a patch for this problem.
I do not think this is an improvement. It will result in omitting
quotes in some cases where they're not optional. Try it with a
value such as "all", for example.regards, tom lane