Improved tab completion for PostgreSQL parameters in enums
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t44912psql -h localhost -U postgresBuilt from patchset v1 (message #1), July 27, 2026 at 04:09 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t44912_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t44912_1 && git checkout t44912_1Patchset v1 (message #1) is on t44912_1
On Wed, Oct 06, 2021 at 02:24:40PM +0900, bt21masumurak wrote:
If you do tab completion in a situation like A, you will see ["on"] instead
of [on].A : "ALTER SYSTEM SET wal_compression TO "
I made a patch for this problem.
This would break the completion of enum entries that require quotes to
work properly for some of their values, like
default_transaction_isolation.
--
Michael
bt21masumurak <bt21masumurak@oss.nttdata.com> writes:
If you do tab completion in a situation like A, you will see ["on"]
instead of [on].
A : "ALTER SYSTEM SET wal_compression TO "
I made a patch for this problem.
I do not think this is an improvement. It will result in omitting
quotes in some cases where they're not optional. Try it with a
value such as "all", for example.
regards, tom lane
Thank you for comments.
I do not think this is an improvement. It will result in omitting
quotes in some cases where they're not optional. Try it with a
value such as "all", for example.
This would break the completion of enum entries that require quotes to
work properly for some of their values, like
default_transaction_isolation.
I understand these comments, and the proposal was withdrawn.
Regards,
Kosei Masumura
2021-10-06 23:34 に Tom Lane さんは書きました:
Show quoted text
bt21masumurak <bt21masumurak@oss.nttdata.com> writes:
If you do tab completion in a situation like A, you will see ["on"]
instead of [on].A : "ALTER SYSTEM SET wal_compression TO "
I made a patch for this problem.
I do not think this is an improvement. It will result in omitting
quotes in some cases where they're not optional. Try it with a
value such as "all", for example.regards, tom lane