Apr 2022

2 commits
Remove some recently-added pg_dump test cases.
22 Apr 2022Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3Also in: pgsql: Allow db.schema.table patterns, but complain about random garbag
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Removes five wildcard-sensitive cases from src/bin/pg_dump/t/002_pg_dump.pl following Thomas Munro's Windows failure report #77 and the glob-expansion diagnosis #78 #79. No attached patchset contains these removals.

  • Thomas Munrosaw the final versionLLM analysis, 99% sureReported the Windows failure in tests from #75 and identified IPC::Run escaping differences as a likely cause before the corrective commit #77 #79.
Allow db.schema.table patterns, but complain about random garbage.
20 Apr 2022Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3
LLM analysis, 100% surelanded as postedfrom patchset #751 of 6 reviewers saw the final version

All added and removed lines across the eleven changed files match #75 exactly, including the final parsing fix and expanded tests; Robert Haas confirmed committing the patches in #76.

  • Justin Pryzbysaw an earlier versionLLM analysis, 96% sureEndorsed the patch's regclass-compatible behavior and checked its error-message rationale, with subsequent parsing changes before the final attachment #53 #66 #72.
  • Tom Lanesaw an earlier versionLLM analysis, 96% sureCritiqued duplicated caller-side validation and reviewed frontend API stability for backpatching before the final parsing correction #64 #73.
  • David G. Johnstonsaw an earlier versionLLM analysis, 86% sureApproved accepting the current database prefix and evaluated the compatibility consequences, before later parsing fixes #54 #71.
  • Stephen Frostsaw an earlier versionLLM analysis, 85% sureBefore the first indexed patch, advocated the adopted behavior of accepting the current database name while rejecting arbitrary prefixes #17.
  • Greg Starksaw an earlier versionLLM analysis, 81% sureIdentified the risk of callers accepting an invalid parse without checking the returned metadata and discussed centralizing validation before subsequent revisions #67.
  • Robert Haassaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Mark DilgerLLM1
Reviewer
Robert Haascommitter1
Committer
Robert Haas2

N LLM means N of the credits come from LLM analysis, not from commit trailers.