Jan 2022

2 commits
Clean up messy API for src/port/thread.c.
11 Jan 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #19

Applying both patches from #19 to the parent of 98e93a1fc9 reproduces the committed files except for removal of an obsolete two-line gethostbyname comment in src/port/thread.c. Both patches were combined into one commit.

Prefer $HOME when looking up the current user's home directory.
10 Jan 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 96% suremodified before commitmoderate changesfrom patchset #11 of 8 reviewers saw the final version

376ce3e404 implements the fallback behavior of #1, explicitly restored in #18, without the documentation changes from #10. Compared with the original attachment, it removes redundant includes, adjusts declarations and comments, and makes psql home-lookup failure nonfatal with a guarded chdir call.

  • Alvaro Herrerasaw an earlier versionLLM analysis, 89% sureAlvaro accepted honoring modified HOME as reasonable in #2, before the subsequent psql error-handling changes.
  • Michael Paquiersaw an earlier versionLLM analysis, 90% sureMichael identified duplicated home-directory logic across the three modified files and recommended consolidation in #3, before the committed psql logic changes.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 97% sureKyotaro raised security concerns in #4 and endorsed honoring HOME in #6 after Anders explained the setuid distinction, before the subsequent psql logic changes.
  • Daniel Gustafssonsaw an earlier versionLLM analysis, 82% sureDaniel questioned portability across supported Unix systems in #7, prompting Anders's platform-specific explanation in #8, before the committed psql logic changes.
  • Chapman Flacksaw an earlier versionLLM analysis, 88% sureChapman endorsed changing the default behavior instead of adding an option in #9, before the subsequent psql error-handling changes.
  • Justin Pryzbysaw an earlier versionLLM analysis, 96% sureJustin reported that children of init can lack HOME in #14, challenging the fallback removal in #10 before that behavior was changed again.
  • Christoph Moench-Tegedersaw an earlier versionLLM analysis, 99% sureChristoph identified daemon and walreceiver compatibility risks in #15 and confirmed absent HOME across Linux services in #17, prompting restoration of the fallback.
  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Anders KaseorgLLM1
Tom LaneLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.