Oct 2021

2 commits
In pg_dump, use simplehash.h to look up dumpable objects by OID.
22 Oct 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #12 of 2 reviewers saw the final version

The commit preserves the four-file hash-table replacement from #1. Comparing reconstructed source shows only seven added object-type assertions and associated local variables in src/bin/pg_dump/common.c, apart from rebase differences.

  • Nathan Bossartsaw the final versionLLM analysis, 100% sureNathan tested the patch on 200,000 tables and reported no performance difference #4; only light assertion additions followed.
  • Andres Freundsaw the final versionLLM analysis, 100% sureAndres measured binary sizes and profiled the patch #3 #6, then supported landing it and suggested unconditional hash-table initialization #16.
Fix frontend version of sh_error() in simplehash.h.
22 Oct 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.1REL_13_STABLE13.5
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Neither attachment changes src/include/lib/simplehash.h; Andres identified that frontend sh_error() incorrectly returns #16, and Tom proposed pg_log_fatal() followed by exit(1) #17. The commit implements that fix, adds unlikely() annotations and copyright text, and credits Andres.

  • Andres Freundsaw the final versionLLM analysis, 100% sureAndres reported the returning sh_error() defect before the commit #16 and is explicitly credited for identifying it in 974aedcea4.

Credits across 2 commits

Author
Tom LaneLLM1
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.