Dec 2021

20 commits
Remove psql support for server versions preceding 9.2.
16 Dec 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Implements the separately announced psql cleanup #62, removing pre-9.2 branches across src/bin/psql and extending the startup warning to too-old servers; the attachment contains no psql changes.

  • Peter Eisentrautsaw the final versionLLM analysis, 82% sureProposed aligning psql with pg_dump's ten-major-release compatibility window, producing the adopted 9.2 cutoff #38.
Clean up some more freshly-dead code in pg_dump and pg_upgrade.
16 Dec 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Justin identified overlooked branches in pg_upgrade/function.c and option.c #68, and Tom acknowledged leftovers from the former 9.0 cutoff #69. The commit removes those and additional dead pg_dump code absent from the attached patch.

  • Justin Pryzbysaw the final versionLLM analysis, 100% sureIdentified obsolete PL/Python and socket-handling branches that prompted this follow-up cleanup, and is credited in the commit message #68 c49d926833.
Remove pg_dump's --no-synchronized-snapshots switch.
15 Dec 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Directly implements Tom's proposal to remove --no-synchronized-snapshots after raising the server cutoff #65, changing pg_dump.c, pg_backup.h and documentation; the attached draft retained the option.

Remove pg_upgrade support for upgrading from pre-9.2 servers.
15 Dec 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #340 of 1 reviewer saw the final version

Extracts the pg_upgrade portion of #34, retaining its large-object metadata and tablespace cleanup while raising the cutoff to 9.2. Additional changes simplify tablespace queries, visibility-map copying and server startup in info.c, relfilenode.c and server.c.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 86% sureRequested replacing the draft's round-number cutoff with a release-count policy yielding 9.2, after which additional compatibility branches were removed #38 #44.
Remove pg_dump/pg_dumpall support for dumping from pre-9.2 servers.
14 Dec 2021Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #340 of 1 reviewer saw the final version

Extracts the pg_dump/pg_dumpall portion of #34, preserving removals such as guessConstraintInheritance(), format_function_arguments_old() and dumpGroups(). It raises the cutoff from 9.0 to 9.2, removes additional catalog-query alternatives and rewrites database and role configuration dumping to use unnest().

  • Peter Eisentrautsaw an earlier versionLLM analysis, 94% sureExplicitly requested changing the attached patch's cutoff to follow a ten-major-release policy, which Tom adopted before further query simplifications #38 #62.
Suppress -Warray-bounds warning in 9.2's xlog.c.
13 Dec 2021Tom LaneREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Adds unreachable abort() calls after PANIC in src/backend/access/transam/xlog.c to silence 9.2's gcc array-bounds warning, completing the clean-build work announced in #62 and reported in #63. No attached patch covers this file.

Suppress -Wformat-overflow warnings in 9.2's xml.c.
13 Dec 2021Tom LaneREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Changes the non-libxml fallback in src/backend/utils/adt/xml.c from NULL to an empty string to suppress a 9.2 format-overflow warning, implementing the warning-cleanup policy #52 #62. This change is outside the attachment.

Disable -Wsometimes-uninitialized warnings in the 9.2 branch.
13 Dec 2021Tom LaneREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Adds configure detection and suppression of clang's -Wsometimes-uninitialized for 9.2, following the discussion of disabling unreliable warnings rather than backpatching error-control-flow infrastructure #45 #50.

Fix function return type confusion
13 Dec 2021Tom LaneREL9_2_STABLEunreleased
LLM analysis, 100% surewritten from the discussion, no matching patch

Changes MANDATORY_AUTH_ARG in src/backend/libpq/hba.c to return NULL instead of false, backpatching the specific return-type correction Tom identified during his 9.2 build experiment #45.

Fix compiler warning
13 Dec 2021Tom LaneREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Enlarges parseQuery()'s variable buffer from 12 to 13 bytes in contrib/pgbench/pgbench.c, backpatching a format-overflow warning fix under the accepted clean-build policy #52 #62.

Silence another gcc 11 warning.
13 Dec 2021Tom LaneREL9_4_STABLEunreleasedREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Adds the negative argument-count guard and uses memset in src/backend/optimizer/util/clauses.c, another application of the warning fix selected for the old-branch buildability effort #62. It has no matching attached patch.

Suppress uninitialized-variable warning in guc.c.
13 Dec 2021Tom LaneREL9_5_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Initializes varsourceline when no source filename exists in RestoreGUCState() in src/backend/utils/misc/guc.c, suppressing a 9.5 warning under the agreed maintenance policy #52 #62.

Suppress -Warray-parameter warnings in pgcrypto/sha2.c.
13 Dec 2021Tom LaneREL9_6_STABLEunreleasedREL9_5_STABLEunreleasedREL9_4_STABLEunreleasedREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Adds explicit digest array lengths to four SHA finalizer definitions in contrib/pgcrypto/sha2.c to eliminate array-parameter warnings, extending the clean-build work down to 9.2 #62 #63.

Reformat imath.c macro to remove -Wmisleading-indentation warnings.
13 Dec 2021Tom LaneREL_11_STABLE11.15REL_10_STABLE10.20REL9_6_STABLEunreleasedREL9_5_STABLEunreleasedREL9_4_STABLEunreleasedREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Reformats the CLAMP macro in contrib/pgcrypto/imath.c to remove misleading-indentation warnings discovered while testing old branches, implementing the expanded warning-cleanup scope #50 #62.

Clean up compilation warnings coming from PL/Perl with clang-12~
12 Dec 2021Tom LaneREL9_6_STABLEunreleasedREL9_5_STABLEunreleasedREL9_4_STABLEunreleasedREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Backpatches configure support for suppressing clang's compound-token-split-by-macro warnings from PL/Perl, consistent with retaining Perl for compatibility testing and cleaning compiler output #47 #62.

Make ecpg's rjulmdy() and rmdyjul() agree with their declarations.
12 Dec 2021Tom LaneREL9_4_STABLEunreleasedREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Aligns rjulmdy() and rmdyjul() definitions with their pointer declarations in src/interfaces/ecpg/compatlib/informix.c, implementing the old-branch warning cleanup #62.

Use -Wno-format-truncation and -Wno-stringop-truncation, if available.
12 Dec 2021Tom LaneREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Backpatches compiler-option detection in config/c-compiler.m4 and configure.in to suppress truncation and unused-command-line-argument warnings, implementing the clean-build policy #50 #62.

Make pg_upgrade's test.sh less chatty.
12 Dec 2021Tom LaneREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 100% surewritten from the discussion, no matching patch

Implements Tom's explicit proposal to backpatch quieter pg_upgrade tests #50: contrib/pg_upgrade/test.sh adds -A trust while retaining -N, and removes shell tracing and its trailing echo. The attachment #34 instead removes obsolete upgrade cases and contains none of these changes.

Add checks for valid multibyte character length in UtfToLocal, LocalToUtf.
12 Dec 2021Tom LaneREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 99% surewritten from the discussion, no matching patch

Backpatches the multibyte conversion length checks and initialization into src/backend/utils/mb/conv.c on another old branch as part of the clean-build work #62. These backend changes are absent from the attachment.

Use return instead of exit() in configure
12 Dec 2021Tom LaneREL9_4_STABLEunreleasedREL9_3_STABLEunreleasedREL9_2_STABLEunreleased
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Backpatches the configure test correction identified by Tom's macOS experiments #5 #45, replacing exit() with return and declaring main() as int in config/c-compiler.m4 and config/c-library.m4. The commit explicitly credits the original patch to Peter Eisentraut.

  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 20 commits

Author
Tom LaneLLM2
Peter EisentrautLLM1
Reviewer
Tom Lanecommitter1
Committer
Tom Lane20

N LLM means N of the credits come from LLM analysis, not from commit trailers.