Aug 2022

3 commits
Fix a bug in roles_is_member_of.
31 Aug 2022Robert Haasmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #1011 of 1 reviewer saw the final version

The acl.c fix and both privileges regression files match #101 exactly modulo patch metadata; Robert Haas confirms the commit in #107.

  • Nathan Bossartsaw the final versionLLM analysis, 100% sureCaught the machine-dependent test output in #98, examined the ADMIN/inheritance semantics in #102, and explicitly approved the final patch in #105.
docs: Fix up some out-of-date references to INHERIT/NOINHERIT.
29 Aug 2022Robert Haasmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #941 of 1 reviewer saw the final version

Matches #94 except for a period inserted before “After” in doc/src/sgml/user-manag.sgml, exactly the correction requested in #95 and acknowledged in #96.

  • Nathan Bossartsaw the final versionLLM analysis, 100% sureApproved #94 subject to adding the missing period in #95, which the committed patch incorporates.
Allow grant-level control of role inheritance behavior.
25 Aug 2022Robert Haasmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #911 of 4 reviewers saw the final version

Compared with #91, the commit removes an obsolete WITH INHERIT DEFAULT explanation from acl.c and bumps src/include/catalog/catversion.h; the implementation otherwise matches modulo formatting.

  • Nathan Bossartsaw an earlier versionLLM analysis, 99% sureReviewed compatibility and implementation in #63, #73, and #80, before the grant-time model and subsequent grantor integration were finalized.
  • Tushar Ahujasaw the final versionLLM analysis, 100% sureFound dump and upgrade failures in #82 and #85, verified their fixes, and retested the final attachment successfully in #92.
  • Tom Lanesaw an earlier versionLLM analysis, 96% sureIdentified the existing-dump compatibility problem and proposed retaining rolinherit as the default for subsequent grants in #44, the design explicitly adopted in #79.
  • Peter Eisentrautsaw an earlier versionLLM analysis, 90% sureObjected to removing role-level INHERIT/NOINHERIT and proposed retaining it with per-grant overrides in #60, prompting the redesign represented by #72.

Mar - Apr 2022

3 commits
Use has_privs_for_roles for predefined role checks: round 2
2 Apr 2022Joe Conwaymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #323 of 3 reviewers saw the final version

Exactly takes the three previously withheld files from #32: basebackup_to_shell.c, basebackup_server.c, and ref/pg_basebackup.sgml. Joe Conway confirms applying these changes as originally posted in #41.

  • Robert Haassaw the final versionLLM analysis, 99% sureExplicitly accepted changing both basebackup membership checks to has_privs_of_role() in #39.
  • Stephen Frostsaw the final versionLLM analysis, 94% sureExamined the replication-connection exception and accepted using has_privs_of_role() while discussing the required semantics in #36.
  • Joshua Brindlesaw the final versionLLM analysis, 87% sureFlagged that replication connections cannot SET ROLE to recover blocked privileges in #33, prompting review of Joe Conway's newly added basebackup checks.
Document basebackup_to_shell.required_role.
30 Mar 2022Robert Haasmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: pgsql: Add 'basebackup_to_shell' contrib module. (part of a posted patchset)
Use has_privs_for_roles for predefined role checks
28 Mar 2022Joe Conwaymaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #323 of 3 reviewers saw the final version

Exactly matches the 23 non-basebackup files of #32, whose header credits Joshua Brindle. In #38, Joe Conway explicitly says he removed his basebackup additions and committed Joshua's patch with the editorial correction already present in that attachment.

  • Stephen Frostsaw the final versiontrailerReviewed the original checks and requested a comment correction in #6, then discussed the subsequently withheld basebackup additions in #36; the committed core changed only lightly.
  • Nathan Bossartsaw the final versiontrailerFound missing documentation in #8, approved its revision in #10, and reaffirmed support in #29; only rebases and editorial changes followed in the committed core.
  • Joe Conwaysaw the final versiontrailerReported build verification in #30, performed the detailed review and revision in #32, and reviewed the final selection as committer in #38.

Credits across 6 commits

Author
Robert HaasLLM4
Joe ConwayLLM1
Joshua Brindle1
Reviewer
Joe Conway1
Nathan Bossart1
Stephen Frost1
Committer
Robert Haas4
Joe Conway2

N LLM means N of the credits come from LLM analysis, not from commit trailers.