Jul 2022

4 commits
Mark all symbols exported from extension libraries PGDLLEXPORT.
18 Jul 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #131 of 1 reviewer saw the final version

The third patch in #13 has an identical stable patch ID: all eight files adding PGDLLEXPORT annotations match the commit.

  • Tom Lanesaw the final versiontrailerTom tested and questioned annotation requirements in #4, then reviewed the final series and judged it committable in #14.
Default to hidden visibility for extension libraries where possible
18 Jul 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #130 of 1 reviewer saw the final version

Matches the fourth patch in #13, with CFLAGS_SL_MOD/CXXFLAGS_SL_MOD renamed to *_SL_MODULE and explanatory comments added or revised. Both the attachment and commit credit Tom Lane as co-author alongside sender Andres Freund.

  • Laurenz Albesaw an earlier versionLLM analysis, 88% sureLaurenz supported the proposal and raised compatibility concerns about removing exported symbols in #2, before PGXS MODULES support and MSVC export changes were added.
Remove now superfluous declarations of dlsym()ed symbols.
18 Jul 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #131 of 1 reviewer saw the final version

The second patch in #13 has an identical stable patch ID, removing the same 64 lines of redundant declarations across 31 files.

  • Tom Lanesaw the final versiontrailerTom reviewed the four-patch series in #14 and called it committable, with no requested changes to the declaration-removal patch.
Add central declarations for dlsym()ed symbols
18 Jul 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #131 of 1 reviewer saw the final version

Matches the first patch in #13, with only the src/include/fmgr.h explanatory comment rewritten using Tom's suggested wording from #14; the declarations are unchanged.

  • Tom Lanesaw the final versiontrailerTom examined declaration compatibility in #10 and supplied the final central-declaration comment wording in #14.

Credits across 4 commits

Author
Andres Freund4
Tom Lane1
Reviewer
Tom Lane3
Committer
Andres Freund4