model-writtenrun 5213 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Andres Freund proposed hiding extension-library symbols by default and explicitly exporting entry points in #1, motivated by simpler Meson support, fewer exported symbols, and better code generation; annotating the entire backend was deliberately outside scope.
- Laurenz Albe raised compatibility concerns about extensions relying on existing exports in #2, and Andres answered in #3 that cross-extension dependencies were uncommon and additional exports could be added when needed.
- Tom Lane rebased and revised the prototype in #4, leaving PGDLLIMPORT unchanged and reporting successful GCC and Clang testing, while questioning whether all the export annotations were necessary.
- Andres discovered that MODULES-style extensions bypassed the visibility flags in #5; Justin Pryzby supplied Windows failure evidence for the ltree annotations in #6, and Andres confirmed their necessity in #7.
- Tom questioned MSVC's declaration rules in #10, and Andres established in #12 that the first declaration must carry the export attribute, explaining why central declarations could preserve extension compatibility.
- Peter Eisentraut suggested converting worker_spi to MODULE_big in #11, but Andres rejected differing export rules between module styles and supplied a four-patch series based on Tom's revision in #13, adding PGXS coverage, declaration cleanup, and removal of automatic MSVC extension exports.
- Tom judged the series committable in #14 while requesting clearer comments and flag names; Andres explained why libraries using explicit export lists must remain exempt in #15, and Tom accepted that distinction and the MODULE spelling in #16.
- The first two patches from #13 landed as f2b73c8d75, with Tom's comment wording, and fd4bad1655, with the declaration removals unchanged.
- The visibility-switch patch from #13 landed as 089480c077 with flag renaming and comment edits; a commit-script mistake placed it before its export-annotation prerequisite, which then landed unchanged as 8cf64d35ea.
- After the main landing, Andres proposed extending visibility detection beyond GCC in #17 and supplied the follow-up patch in #18; Tom supported trying it in #19.
- Testing revealed that xlc silently accepted -fvisibility as an input file rather than a supported option, so Andres revised detection to use -qvisibility on AIX and included an AIX build cleanup in #20, reporting successful tests with GCC and proprietary compilers on AIX and Solaris.
- Andres reported the follow-up committed in #21 and reopened whether pg_config should expose module visibility flags; Tom opposed expanding configuration support for non-PGXS extensions in #22, and Andres accepted leaving that unchanged in #23, closing the thread without a pending patch.