[PATCH] fix references to like_regex

Started by Gilles Daroldover 4 years ago3 messageshackers
Jump to latest
#1Gilles Darold
gilles@darold.net

Hi,

Since we have the regexp_like operator I have found that there is two
references in the documentation about PostgreSQL lacking of LIKE_REGEX
implementation. Here is a patch to fix the documentation. I simply
remove the reference to non exist of LIKE_REGEX in PostgreSQL in chapter
"9.7.3.8 Differences from XQuery"  And try to modify chapter "9.16.2.3.
SQL/JSON Regular Expressions" to mention the REGEXP_LIKE operator. For
the second fix there should be better wording.

Best regards,

--
Gilles Darold

Attachments:

0001-like_regex-doc-fix-v1.patchtext/x-patch; charset=UTF-8; name=0001-like_regex-doc-fix-v1.patchDownload+6-20
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Gilles Darold (#1)
Re: [PATCH] fix references to like_regex

Gilles Darold <gilles@migops.com> writes:

Since we have the regexp_like operator I have found that there is two
references in the documentation about PostgreSQL lacking of LIKE_REGEX
implementation. Here is a patch to fix the documentation. I simply
remove the reference to non exist of LIKE_REGEX in PostgreSQL in chapter
"9.7.3.8 Differences from XQuery"  And try to modify chapter "9.16.2.3.
SQL/JSON Regular Expressions" to mention the REGEXP_LIKE operator. For
the second fix there should be better wording.

I don't think we should change these (yet). regexp_like() is *not*
LIKE_REGEX, precisely because it's using a slightly different
regular-expression language than what the spec calls for.
At some point we may provide a skin for the regexp engine that
duplicates the spec's definition, and then we can implement
LIKE_REGEX for real.

regards, tom lane

#3Gilles Darold
gilles@darold.net
In reply to: Tom Lane (#2)
Re: [PATCH] fix references to like_regex

Le 02/11/2021 à 16:50, Tom Lane a écrit :

Gilles Darold <gilles@migops.com> writes:

Since we have the regexp_like operator I have found that there is two
references in the documentation about PostgreSQL lacking of LIKE_REGEX
implementation. Here is a patch to fix the documentation. I simply
remove the reference to non exist of LIKE_REGEX in PostgreSQL in chapter
"9.7.3.8 Differences from XQuery"  And try to modify chapter "9.16.2.3.
SQL/JSON Regular Expressions" to mention the REGEXP_LIKE operator. For
the second fix there should be better wording.

I don't think we should change these (yet). regexp_like() is *not*
LIKE_REGEX, precisely because it's using a slightly different
regular-expression language than what the spec calls for.
At some point we may provide a skin for the regexp engine that
duplicates the spec's definition, and then we can implement
LIKE_REGEX for real.

Thanks for clarifying, I thought it was an oversight.

Regards

--
Gilles Darold