May 2022

1 commit
logging: Also add the command prefix to detail and hint messages
30 May 2022Peter Eisentrautmaster15beta2REL_19_STABLE15beta2REL_18_STABLE15beta2REL_17_STABLE15beta2REL_16_STABLE15beta2REL_15_STABLE15beta2
LLM analysis, 100% surelanded as postedfrom patchset #48

Both hunks match #48: src/common/logging.c removes the primary-message restriction on the prefix, and src/bin/pg_dump/t/003_pg_dump_with_server.pl expects the prefixed detail line.

Apr 2022

2 commits
Remove not-very-useful early checks of __pg_log_level in logging.h.
12 Apr 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #431 of 1 reviewer saw the final version

The commit implements #43's centralized filtering and retains the DEBUG guards. It additionally simplifies the nine non-debug logging macros in src/include/common/logging.h by removing their now-unnecessary do/while wrappers.

  • Peter Eisentrautsaw the final versionLLM analysis, 99% surePeter approved the change and discussed when early checks are useful in #44, before the commit; only light macro cleanup followed.
Improve frontend error logging style.
8 Apr 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #334 of 7 reviewers saw the final version

The commit retains #33's API and frontend conversions, rebasing them over newer call sites and tests. Additional edits remove 'Check your installation' hints, correct an initdb close-error message, and refine message wording, as confirmed in #42.

  • Robert Haassaw an earlier versionLLM analysis, 95% sureRobert advocated consistent frontend error handling in #11 and is explicitly credited by the commit, but the full call-site conversion and exit-wrapper revisions followed his review.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 99% sureKyotaro reviewed the draft's detail/hint verbosity behavior in #6 and is credited by the commit, before the full conversion and later API refinements.
  • Peter Eisentrautsaw the final versionLLM analysis, 99% surePeter challenged logging-related flow control in #10 and #24, then endorsed #33 and requested message refinements in #35 that informed the final edits.
  • Daniel Gustafssonsaw the final versionLLM analysis, 100% sureDaniel checked the call-site conversions for unintended control-flow changes and supplied detailed message corrections in #34, with only light changes before commit.
  • Andres Freundsaw the final versionLLM analysis, 98% sureAndres proposed the separate pg_fatal shortcut in #18 and endorsed the revised patch after inspecting its call sites in #32, followed by rebasing and light edits.
  • Michael Paquiersaw the final versionLLM analysis, 97% sureMichael raised pg_dump cleanup concerns in #13 and reviewed the revised severity and detail/hint macros in #28, after which the architecture remained unchanged.
  • Euler Taveirasaw an earlier versionLLM analysis, 85% sureEuler endorsed the consolidation proposal accompanying #17 in #23, before the final decision on FATAL removal and the expanded wrapper conversions.

Credits across 3 commits

Author
Tom LaneLLM2
Peter EisentrautLLM1
Committer
Tom Lane2
Peter Eisentraut1

N LLM means N of the credits come from LLM analysis, not from commit trailers.