Nov 2021

1 commit
Harden be-gssapi-common.h for headerscheck
26 Nov 2021Alvaro Herreramaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.2REL_13_STABLE13.6+1 more
LLM analysis, 100% surelanded as postedfrom patchset #42 of 2 reviewers saw the final version

Both hunks and all four added lines in src/include/libpq/be-gssapi-common.h exactly match #4; the commit expands the explanation and specifies backpatching to PostgreSQL 12 f744519326.

  • Stephen Frostsaw the final versionLLM analysis, 97% sureStephen questioned guarding the header's contents rather than its inclusion sites #5, preferred a headerscheck exclusion #8, and ultimately accepted the unchanged approach #10.
  • Tom Lanesaw the final versionLLM analysis, 99% sureTom endorsed the proposed ENABLE_GSS guard because headers should not assume their inclusion context and opposed excluding the header from headerscheck #9.

Credits across 1 commit

Author
Alvaro HerreraLLM1
Committer
Alvaro Herrera1

N LLM means N of the credits come from LLM analysis, not from commit trailers.