Nov 2021

2 commits
Disable unused-variable warning C4101 in MSVC
30 Nov 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch3 of 4 reviewers saw the final version

The commit adds C4101 to disablewarnings in src/tools/msvc/Project.pm, a change absent from both attachments. Daniel proposed this alternative in #15 and #18, Tom supported it in #20, and Daniel confirmed application in #23.

  • Alvaro Herrerasaw an earlier versionLLM analysis, 92% sureIn #3, he challenged the original conditional-declaration workaround in #1 and preferred fixing the annotation across platforms, before the approach changed to global warning suppression.
  • Tom Lanesaw the final versionLLM analysis, 99% sureHe rejected changing correctly annotated code in #4 and explicitly advocated the adopted C4101 suppression in #20, explaining how other builds would catch unused variables.
  • Greg Nancarrowsaw the final versionLLM analysis, 88% sureHe reported that [[maybe_unused]] failed in MSVC C mode in #11 and assessed the drawbacks of the proposed global suppression in #16.
  • Andrew Dunstansaw the final versionLLM analysis, 97% sureHe challenged disabling the warning in #19 and identified the risk of undetected unused variables in Windows-only code, with Msys GCC as mitigation, in #22.
Remove PF_USED_FOR_ASSERTS_ONLY from variables in general use
30 Nov 2021Daniel Gustafssonmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #71 of 1 reviewer saw the final version

Both hunks match #7: removal of PG_USED_FOR_ASSERTS_ONLY from fsstate in process_pending_request() and rd_index in get_index_column_opclass(). The changed files and added and removed lines match completely.

  • Greg Nancarrowsaw the final versiontrailerGreg explicitly agreed in #16 with applying the annotation-removal patch from #7, which landed unchanged.

Credits across 2 commits

Author
Daniel GustafssonLLM1
Reviewer
Greg Nancarrow1
Committer
Daniel Gustafsson2

N LLM means N of the credits come from LLM analysis, not from commit trailers.