Jan - Feb 2022

5 commits
Add TAP test to automate the equivalent of check_guc, take two
16 Feb 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #410 of 1 reviewer saw the final version

Reintroduces the TAP test from #41 with the simplified regex, but replaces pg_config-based sample discovery with a source-relative path and uses done_testing(). The commit explains that distribution-patched pg_config paths broke the first landing.

  • Justin Pryzbysaw an earlier versiontrailerJustin requested the missing-parameter check in #40 and approved the revised test with a regex simplification in #42, before the subsequent sample-location fix.
Retire src/backend/utils/misc/check_guc
9 Feb 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #34

Exactly extracts the 78-line deletion of src/backend/utils/misc/check_guc attached in #34, leaving the SQL feature to its separate commit; #44 announces retirement after the TAP replacement.

Add TAP test to automate the equivalent of check_guc
9 Feb 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #411 of 1 reviewer saw the final version

The three TAP checks and pg_config-based sample lookup match #41; changes simplify the regex to require an equals sign and adjust comments, as discussed in #42 and confirmed in #44.

  • Justin Pryzbysaw the final versiontrailerJustin identified the missing reverse comparison in #40, then said the revised test looked fine and suggested the adopted regex simplification in #42.
Add PostgreSQL::Test::Cluster::config_data()
8 Feb 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #39

Extracts PostgreSQL::Test::Cluster::config_data() in src/test/perl/PostgreSQL/Test/Cluster.pm from #39, preserving its implementation with POD wording changes; #41 confirms the separate landing. Although originally developed for thread #44230, this attachment is newer than that thread's latest pre-commit patchset, #496849, and its current verdict agrees that this thread supplies the latest matching source.

Introduce pg_settings_get_flags() to find flags associated to a GUC
30 Jan 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #341 of 3 reviewers saw the final version

Preserves the pg_settings_get_flags() implementation from #34, omits check_guc deletion, and adds a catalog-version bump, NULL/nonexistent-name tests, and documentation corrections. The commit explicitly credits Justin, whose implementation Michael revised.

  • Peter Eisentrautsaw an earlier versionLLM analysis, 98% surePeter requested automated checks in #14 and challenged the exposed interface and missing documentation in #28, before the standalone documented function replaced the backing-function attribute.
  • Kyotaro Horiguchisaw an earlier versionLLM analysis, 84% sureKyotaro raised flag-representation readability and width concerns in #19, before the integer interface was replaced by named text-array flags.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Nov - Dec 2021

2 commits
Improve the description of various GUCs
3 Dec 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #5

Updates the same eight guc.c descriptions as #5, with final authentication-delay, checkpoint-warning, and log-rotation wording requested in #6 and #8. The commit credits Justin and Michael jointly.

Fix flags of some GUCs and improve some descriptions
30 Nov 2021Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

Selects seven guc.c hunks from #1: two flag fixes, the compatibility category, the obsolete comment, and three descriptions with wording edits. Unit-flag additions and most description changes are omitted, as explained in #3.

  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 7 commits

Author
Michael Paquier3 LLM5
Justin Pryzby3
Reviewer
Justin Pryzby2
Michael Paquiercommitter2
Committer
Michael Paquier7

N LLM means N of the credits come from LLM analysis, not from commit trailers.