fix a typo in slotfuncs.c
Started by Bharath Rupireddyabout 4 years ago2 messages
Hi,
It seems like there's a following typo in code comments:
- /* determine how many segments slots can be kept by slots */
+ /* determine how many segments can be kept by slots */Attaching a tiny patch to fix it. This typo exists all the way until PG 13.
Regards,
Bharath Rupireddy.
Attachments:
v1-0001-fix-a-typo-in-slotfuncs.c.patchapplication/octet-stream; name=v1-0001-fix-a-typo-in-slotfuncs.c.patchDownload
From 97bc5929d98d4d2f8326dfac6944b04d9a081f32 Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Wed, 1 Dec 2021 06:45:10 +0000
Subject: [PATCH v1] fix a typo in slotfuncs.c
---
src/backend/replication/slotfuncs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/replication/slotfuncs.c b/src/backend/replication/slotfuncs.c
index 46175b7007..d11daeb1fc 100644
--- a/src/backend/replication/slotfuncs.c
+++ b/src/backend/replication/slotfuncs.c
@@ -414,7 +414,7 @@ pg_get_replication_slots(PG_FUNCTION_ARGS)
XLByteToSeg(slot_contents.data.restart_lsn, targetSeg, wal_segment_size);
- /* determine how many segments slots can be kept by slots */
+ /* determine how many segments can be kept by slots */
slotKeepSegs = XLogMBVarToSegs(max_slot_wal_keep_size_mb, wal_segment_size);
/* ditto for wal_keep_size */
keepSegs = XLogMBVarToSegs(wal_keep_size_mb, wal_segment_size);
--
2.25.1
Re: fix a typo in slotfuncs.c
On Wed, Dec 01, 2021 at 12:22:30PM +0530, Bharath Rupireddy wrote:
It seems like there's a following typo in code comments: - /* determine how many segments slots can be kept by slots */ + /* determine how many segments can be kept by slots */Attaching a tiny patch to fix it. This typo exists all the way until PG 13.
Indeed, thanks. I'll fix in a bit.
--
Michael