Jul 2023

2 commits
Report index vacuum progress.
11 Jul 2023Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1372 of 9 reviewers saw the final version

Commits the vacuum-progress half of the two-patch series in #137; all six attached file changes match, with only src/include/catalog/catversion.h added for the catalog-version bump. The attachment and commit explicitly credit Sami Imseih despite Sawada sending the series.

  • Michael Paquiersaw the final versionLLM analysis, 100% sureDesigned the generic increment interface, caught message-decoding errors and checked the reporting paths before posting the formatting revision in #133, after which only light changes followed.
  • Nathan Bossartsaw an earlier versionLLM analysis, 100% sureReviewed counter semantics, failsafe handling and shared-memory sizing, and considered #56 ready in #57, before substantial reporting-infrastructure changes.
  • Andres Freundsaw an earlier versionLLM analysis, 99% sureRejected costly locking and polling, then proposed HandleParallelMessages integration in #110, which drove the asynchronous redesign.
  • Justin Pryzbysaw an earlier versionLLM analysis, 100% sureIdentified missing regression expectations and naming, SQL-formatting and include-order issues in #14, which were addressed in #15.
  • Peter Geoghegansaw an earlier versionLLM analysis, 95% sureExplained why per-index block counts were unreliable in #7 and reviewed failsafe and cycle-count semantics for the split series in #35.
  • Robert Haassaw an earlier versionLLM analysis, 98% sureArgued for DSM and leader-side reporting in #72 and examined progress updates while the leader remained busy in #82.
  • Bertrand Drouvotsaw an earlier versionLLM analysis, 100% sureReviewed documentation, comments and wait-event ordering in #104, with corrections incorporated into #105 before the asynchronous redesign.
  • Greg Starksaw an earlier versionLLM analysis, 83% sureReviewed the initial proposal before the first indexed patchset and suggested total/processed index counters in #4, a concept retained in the final feature.
  • Masahiko Sawadasaw the final versioncommittercommitted the patch
Add new parallel message type to progress reporting.
11 Jul 2023Masahiko Sawadamaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #1372 of 5 reviewers saw the final version

Commits the infrastructure half of #137: all 51 additions across parallel.c, backend_progress.c and backend_progress.h match exactly. The vacuum consumer is committed separately, and both the attachment and commit credit Sami Imseih.

  • Michael Paquiersaw the final versionLLM analysis, 100% sureProposed transmitting increment arguments directly in #126, corrected receiver decoding in #129 and approved the resulting implementation in #133.
  • Andres Freundsaw an earlier versionLLM analysis, 99% sureProposed integrating worker notifications with HandleParallelMessages in #110, and the commit explicitly credits his idea, although the payload API was designed later.
  • Nathan Bossartsaw an earlier versionLLM analysis, 93% sureReviewed the earlier reusable parallel-progress infrastructure and found no substantial remaining issues in #57, before its shared hash was replaced.
  • Robert Haassaw an earlier versionLLM analysis, 91% sureReviewed the predecessor worker-to-leader reporting design in #72 and its callback requirements in #82, before message-based reporting replaced polling.
  • Masahiko Sawadasaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Sami Imseih2
Reviewer
Masahiko Sawadacommitter2
Committer
Masahiko Sawada2