Is ssl_crl_file "SSL server cert revocation list"?
As discussed in the thread [1]/messages/by-id/20211202.134619.1052008069537649171.horikyota.ntt@gmail.com, I find the wording "SSL server
certificate revocation list" as misleading or plain wrong.
I used to read it as "SSL server certificate (of PostgreSQL client)
revocation list" but I find it misleading-ish from fresh eyes. So I'd
like to propose a change of the doc as attached.
What do you think about this?
[1]: /messages/by-id/20211202.134619.1052008069537649171.horikyota.ntt@gmail.com
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Attachments:
fix_crl_doc.patchtext/x-patch; charset=us-asciiDownload+8-9
At Thu, 02 Dec 2021 13:54:41 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
As discussed in the thread [1], I find the wording "SSL server
certificate revocation list" as misleading or plain wrong.
FWIW, I'm convinced that that's plain wrong after finding some
occurances of "(SSL) client certificate" in the doc.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
On 2 Dec 2021, at 06:07, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
At Thu, 02 Dec 2021 13:54:41 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
As discussed in the thread [1], I find the wording "SSL server
certificate revocation list" as misleading or plain wrong.FWIW, I'm convinced that that's plain wrong after finding some
occurances of "(SSL) client certificate" in the doc.
I agree with this, the concepts have been a bit muddled.
While in there I noticed that we omitted mentioning sslcrldir in a few cases.
The attached v2 adds these and removes the whitespace changes from your patch
for easier review.
--
Daniel Gustafsson https://vmware.com/
Attachments:
fix_crl_doc-v2.diffapplication/octet-stream; name=fix_crl_doc-v2.diff; x-unix-mode=0644Download+8-5
On 02.12.21 10:42, Daniel Gustafsson wrote:
On 2 Dec 2021, at 06:07, Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote:
At Thu, 02 Dec 2021 13:54:41 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
As discussed in the thread [1], I find the wording "SSL server
certificate revocation list" as misleading or plain wrong.FWIW, I'm convinced that that's plain wrong after finding some
occurances of "(SSL) client certificate" in the doc.I agree with this, the concepts have been a bit muddled.
While in there I noticed that we omitted mentioning sslcrldir in a few cases.
The attached v2 adds these and removes the whitespace changes from your patch
for easier review.
This change looks correct to me.
On 2 Dec 2021, at 16:04, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
This change looks correct to me.
Thanks for review, I've pushed this backpatched (in part) down to 10.
--
Daniel Gustafsson https://vmware.com/
At Fri, 3 Dec 2021 14:32:54 +0100, Daniel Gustafsson <daniel@yesql.se> wrote in
On 2 Dec 2021, at 16:04, Peter Eisentraut <peter.eisentraut@enterprisedb.com> wrote:
This change looks correct to me.
Thanks for review, I've pushed this backpatched (in part) down to 10.
Thanks for revising and comitting this.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center