Apr 2023

5 commits
Avoid using non-ASCII commentary in daitch_mokotoff.c.
16 Apr 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Implements the stronger fallback proposed in #71: removes the conversion-table comment and replaces remaining non-ASCII comment glyphs with Unicode character names. Its commit message records that d6b5dee42d did not suppress the MSVC warning.

Remove some non-ASCII symbols from a comment.
15 Apr 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

The single comment hunk in contrib/fuzzystrmatch/daitch_mokotoff.c replaces non-letter symbols as Tom Lane proposed in #71 to address hamerkop's code-page warning; no attached patch contains this change.

Remove useless dependencies in daitch_mokotoff_header.pl.
8 Apr 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 2 reviewers saw the final version

Removes the utf8, open, and Data::Dumper imports from daitch_mokotoff_header.pl after the missing-open.pm failure in #66. Tom explains in #69 that the generator needs no non-ASCII processing.

  • Tomas Vondrasaw an earlier versionLLM analysis, 88% sureFlagged the new perl-open dependency and questioned its availability in #3, anticipating the specific dependency problem this commit removes.
  • Andrew Dunstansaw the final versionLLM analysis, 84% sureInvestigated the missing open.pm dependency and explained its separate packaging in #67, before Tom removed the unnecessary imports.
Pacify perlcritic.
8 Apr 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

Changes the Perl I/O layer from :utf8 to :encoding(UTF-8), exactly the inline remedy Andres Freund tested in #64 and Tom agreed to push in #65.

  • Andres Freundsaw the final versionLLM analysis, 100% sureReported that replacing :utf8 with :encoding(UTF-8) worked locally and recommended that fix in #64.
Add support for Daitch-Mokotoff Soundex in contrib/fuzzystrmatch.
7 Apr 2023Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #584 of 6 reviewers saw the final version

Matches the implementation, SQL interface, and regression cases in #58, with committer cleanup of C/Perl style, context arguments, build rules, and documentation, plus a defensive end-of-string guard. Tom describes the changes as mostly cosmetic in #63.

  • Tomas Vondrasaw the final versionLLM analysis, 100% sureProvided the initial detailed review in #3, reported successful UTF-8 tests in #51, and judged the final patch technically ready in #61.
  • Andrew Dunstansaw an earlier versionLLM analysis, 100% sureProposed integrating the function into fuzzystrmatch in #4, which Dag implemented before subsequent algorithm and memory-management reworks.
  • Andres Freundsaw an earlier versionLLM analysis, 100% sureReviewed allocation, encoding conversion, generated headers, extension upgrades, and build integration in #23, prompting the substantial rework in #24.
  • Alvaro Herrerasaw the final versionLLM analysis, 98% sureTested surname matching and advocated arrays in #31 and #38, then reviewed the copyright notices in #52, after which only light changes remained.
  • Paul Ramseysaw the final versionLLM analysis, 99% sureRequested clearer examples in #44 and reported regression-testing difficulties with the revised patch in #50, with only light changes following.
  • Tom Lanesaw the final versioncommittercommitted the patch

Jan 2022

1 commit
Enable routine running of citext's UTF8-specific test cases.
5 Jan 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #171 of 1 reviewer saw the final version

Derives from #17, adding a C-locale exclusion, enabling additional pattern-comparison tests, and checking comparison-result signs instead of platform-specific magnitudes. Tom reports his locale testing and the push in #18.

  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 6 commits

Author
Dag LemLLM2
Reviewer
Tom Lanecommitter2
Committer
Tom Lane6

N LLM means N of the credits come from LLM analysis, not from commit trailers.