Mar 2022

2 commits
Don't bother to attach column name lists to RowExprs of named types.
17 Mar 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #11 of 1 reviewer saw the final version

This commit takes only the cleanup component of the two-patch series in #1. Its changes to prepjointree.c, var.c, rewriteManip.c and primnodes.h match that attachment exactly apart from blob identifiers and hunk offsets.

  • Aleksander Alekseevsaw the final versionLLM analysis, 88% sureAleksander reported examining the proposed code, finding no particular problems and passing the tests in #9, without explicitly separating the two attachments.
Revert applying column aliases to the output of whole-row Vars.
17 Mar 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1REL_14_STABLE14.3REL_13_STABLE13.7+3 morerevert
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #12 of 2 reviewers saw the final version

This commit takes the executor-fix component of #1, with unchanged implementation hunks in execExpr.c, execExprInterp.c and execTuples.c. The only additional edits remove the vv1 view tests and corresponding expected output from the rowtypes regression files; the separate cleanup landed independently.

  • Robert Haassaw the final versionLLM analysis, 99% sureRobert challenged the changed regression expectations in #2 and examined the remaining alias-semantics inconsistency in #6, before accepting that preventing unreadable tables justified proceeding in #8.
  • Aleksander Alekseevsaw the final versionLLM analysis, 100% sureAleksander confirmed that the patch fixed the reported failure, passed the other tests and looked suitable for merging in #9.

Credits across 2 commits

Author
Tom LaneLLM2
Committer
Tom Lane2

N LLM means N of the credits come from LLM analysis, not from commit trailers.