Jul 2022

2 commits
Fix previous commit's ecpg_clocale for ppc Darwin.
3 Jul 2022Noah Mischmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta3REL_14_STABLE14.5REL_13_STABLE13.8+3 more
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit exactly implements Noah Misch's inline fix in #15, explicitly initializing ecpg_clocale to (locale_t) 0 in src/interfaces/ecpg/ecpglib/connect.c to resolve the ppc Darwin shared-library link failure.

  • Tom Lanesaw the final versionLLM analysis, 100% sureBefore the commit, Tom confirmed that explicit initialization fixed the ecpglib build on prairiedog and recommended it over adding -fno-common #19.
ecpglib: call newlocale() once per process.
2 Jul 2022Noah Mischmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta3REL_14_STABLE14.5REL_13_STABLE13.8+3 more
LLM analysis, 100% suremodified before commitlight changesfrom patchset #131 of 1 reviewer saw the final version

The commit preserves the four-file implementation from #13, adding only Tom Lane's explanatory comment about connections_mutex in src/interfaces/ecpg/ecpglib/connect.c #14, plus commit-message corrections and review credit.

  • Tom Lanesaw the final versionLLM analysis, 100% sureTom reviewed the patch as solid and supplied the mutex-protection comment incorporated into the committed version #14.

Credits across 2 commits

Author
Noah MischLLM1
Committer
Noah Misch2

N LLM means N of the credits come from LLM analysis, not from commit trailers.