Feb 2022

1 commit
pg_upgrade: Move all the files generated internally to a subdirectory
6 Feb 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #301 of 6 reviewers saw the final version

The commit matches #30 except for formatting, comments and moving GetDataDirectoryCreatePerm() plus umask() before make_outputdirs() in src/bin/pg_upgrade/pg_upgrade.c, ensuring correct group permissions as explained in #41. The commit explicitly credits Justin Pryzby as author although Michael Paquier sent the source patchset.

  • Bruce Momjiansaw an earlier versionLLM analysis, 93% sureBruce challenged deleting previous logs in #2, supported the directory approach in #5, and checked final-proposal cleanup in #31 and #33, before the committed permissions fix.
  • Tom Lanesaw an earlier versionLLM analysis, 99% sureTom advocated collecting output in a directory in #4 and separating logs into a nested directory in #15, which informed subsequent patches before the location and permissions changes.
  • Andrew Dunstansaw an earlier versionLLM analysis, 93% sureAndrew identified the buildfarm need for a predictable directory name in #6, a requirement adopted by the ensuing directory-based patches before later implementation changes.
  • Daniel Gustafssonsaw an earlier versionLLM analysis, 91% sureDaniel explained why separate diagnostic files must remain available to wrappers and supported a predictable output directory in #10, shaping the implementation before substantial revisions.
  • Peter Eisentrautsaw an earlier versionLLM analysis, 99% surePeter challenged the --outputdir terminology and proposed storing generated files inside the target cluster in #28, adopted in #30 before the final permissions correction.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 1 commit

Author
Justin Pryzby1
Reviewer
Michael Paquiercommitter1
Committer
Michael Paquier1