Apr 2022

2 commits
libpq: Allow IP address SANs in server certificates
1 Apr 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetmoderate changesfrom patchset #441 of 4 reviewers saw the final version

Lands the feature, documentation, and new-behavior tests from #44, with existing-behavior tests split into af9e180495. Peter removes the common inet-header refactoring, uses AF_INET constants, and adds HAVE_INET_PTON configuration, conditional IPv6 handling, and test skips, as confirmed in #45.

  • Andrew Dunstansaw an earlier versionLLM analysis, 98% sureIn #3, Andrew supported omitting IPv4/IPv6 mapping and objected to Common Name fallback when IP SANs exist; fallback logic and parsing subsequently changed.
  • Andres Freundsaw an earlier versionLLM analysis, 83% sureIn #8, Andres reported the concrete Windows unresolved-symbol failure caused by moving pg_inet_net_pton(), which Jacob fixed in #11 before that prerequisite was ultimately dropped.
  • Tom Lanesaw an earlier versionLLM analysis, 99% sureIn #35, Tom applied the series locally and diagnosed failing SSL tests caused by certificate-name handling; the parser replacement and portability changes followed his review.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch
Add SSL tests for IP addresses in certificates
1 Apr 2022Peter Eisentrautmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #442 of 2 reviewers saw the final version

Extracts the existing-behavior tests from #44 into eight src/test/ssl files: IP addresses in Common Name and dNSName SANs, their fixtures, and registration. The six configuration/certificate/key additions match exactly, and the relevant Perl test hunks are preserved.

  • Tom Lanesaw the final versionLLM analysis, 99% sureTom's local test failure report in #35 exposed the broken switch_server_cert() calls used by these tests, and only light test repairs and extraction followed for this committed subset.
  • Peter Eisentrautsaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Jacob Champion2
Reviewer
Peter Eisentrautcommitter2
Co author
Daniel Gustafsson2
Kyotaro Horiguchi2
Committer
Peter Eisentraut2