Jan 2022

3 commits
Extend the options of pg_basebackup to control compression
21 Jan 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% suremodified before commitlight changesfrom patchset #351 of 4 reviewers saw the final version

Matches the interface, documentation, and tests in #35, with a behavior-preserving consolidation of duplicate method comparisons in parse_compress_options() requested in #36. Other differences are formatting, comments, and adaptation to intervening changes in pg_basebackup.c and its TAP tests.

  • Robert Haassaw the final versiontrailerReviewed the interface throughout the thread, requested parser restructuring in #32, and supplied the final condition simplification in #36.
  • Magnus Hagandersaw an earlier versiontrailerObjected to the separate-option interface and proposed combined method, location, and level syntax in #18, before the substantial parser rework.
  • Álvaro Herrerasaw an earlier versiontrailerProposed the backward-compatible composite syntax in #25 and corrected the help syntax in #33, before the parser restructuring in #35.
  • Davidsaw an earlier versiontrailerDavid G. Johnston reviewed the interface choices and compatibility requirements in #26 and #27, before implementation of the composite parser.
Add TAP tests for pg_basebackup with compression
7 Jan 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #101 of 1 reviewer saw the final version

Extracts only the gzip TAP tests from the first patch in #10, leaving its production-code refactor and the separate options patch out. The committed src/bin/pg_basebackup/t/010_pg_basebackup.pl changes differ from that test portion only in formatting.

  • Georgios Kokolatossaw the final versiontrailerIdentified the incorrect zlib skip count in #4 and endorsed the corrected version in #6, after which the extracted tests received only light changes.
Refactor tar method of walmethods.c to rely on the compression method
7 Jan 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #100 of 1 reviewer saw the final version

Extracts the pg_basebackup.c and walmethods.c refactor from the first patch in #10, excluding its tests and the separate options patch. The commit additionally guards tar_write()'s gzip branch by compression method and retains an ENOSYS fallback outside HAVE_LIBZ.

  • Georgios Kokolatossaw an earlier versiontrailerReviewed and endorsed the original refactor in #4 and #6, before its extraction and the additional tar_write() branch handling.

Credits across 3 commits

Author
Michael PaquierLLM3
Reviewer
Georgios Kokolatos2
Alvaro Herrera1
David1
Magnus Hagander1
Robert Haas1
Committer
Michael Paquier3

N LLM means N of the credits come from LLM analysis, not from commit trailers.