model-writtenrun 5857 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed a Boolean node to replace string-and-cast SQL Boolean constants and Integer nodes carrying Boolean flags, making their intent and types clearer #1.
- Pavel Stehule clarified that this was an internal node representation without locale-dependent semantics, while Julien Rouhaud approved the patch subject to updating nodeTokenType() and nodeRead() comments #4 #5.
- Ashutosh Bapat questioned Boolean-string parsing consistency and the change in unnamed Boolean result columns, while Tom Lane proposed distinct value-field names to help catch incorrect node access #13 #14.
- Alvaro Herrera accepted the change from a default column name of bool to ?column? as consistent with other literals; Josef Šimánek examined compatibility implications, and Tom Lane judged the practical risk low #15 #18 #19.
- Zhihong Yu suggested removing redundant comparisons with zero after boolVal() and asked whether uppercase Boolean strings should also be recognized #16.
- Andres Freund proposed widening Integer nodes to int64, but Tom Lane warned about type-resolution consequences; Peter explained that separating Boolean uses was preparatory work and deferred further int64 analysis #20 #21 #23.
- Andres Freund also suggested separating node introduction from caller conversion, using shorter serialized Boolean tokens, and reconsidering the visible column-name change; the final series retained combined introduction and conversion, true/false tokens, and the changed column names #22 #25.
- Peter expanded the submission into three patches: an AlterRole() refactor replacing sentinel-valued variables with option-presence checks, Tom Lane's field-renaming proposal, and the updated Boolean implementation incorporating comment and boolVal() cleanup #24.
- Peter's final revision added a NULL assignment after an assertion in makeAConst() to address cfbot feedback, and Pavel subsequently reported that application, compilation, and make check-world succeeded before marking the series ready for committer #25 #26.
- Peter committed the final series' AlterRole() refactor and value-field renaming unchanged on January 14 as 93415a3b5a and c4cc2850f4, respectively #25.
- The Boolean-node patch landed unchanged on January 17 as 941460fcf7, and Peter closed the thread by confirming that the entire series had been committed #25 #27.