model-writtenrun 5867 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Peter Eisentraut proposed three patches to make fixed-parameter, variable-parameter, and callback parsing APIs parallel, renaming misleading functions and extracting two missing entry points; he separately suggested eventually removing the analyze-and-rewrite wrappers by relocating statistics and tracing responsibilities #1.
- Nathan Bossart found the withcb name understandable and supported further deduplication after reading the patches #2.
- Peter questioned why the submission was marked Waiting on Author when it still applied and built #3, and Nathan clarified that his outstanding feedback concerned additional wrapper deduplication, which could be handled separately #4.
- The first patch from #1 landed on March 4 as 791b1b71da, preserving the renames and const additions with only an explanatory comment adjustment.
- The second patch from #1 landed on March 7 as 25751f54b8, consolidating variable-parameter analysis and rewriting with only comment punctuation changed.
- The third patch from #1 landed unchanged apart from its base on March 9 as df4c3cbd8f, extracting parse_analyze_withcb().
- Peter confirmed that all original patches were committed and deferred further deduplication to future work #5; Nathan accepted that outcome in the final reply #6.