Mar 2022

1 commit
Revert "graceful shutdown" changes for Windows.
22 Mar 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1revert
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

29992a6a50 removes Windows shutdown/closesocket calls from socket_close() in src/backend/libpq/pqcomm.c, implementing the HEAD revert requested in #47 and confirmed in #49. No attached patch proposes this revert; the later #51 proposes its inverse.

  • Thomas Munrosaw the final versionLLM analysis, 100% sureThomas explained that the replacement fix would miss PostgreSQL 15 in #47 and explicitly approved applying the existing rollback to HEAD in #49.
  • Alexander Lakhinsaw the final versionLLM analysis, 92% sureAlexander tested removal of socket shutdown and close calls and reported that repeated postgres_fdw disconnection tests then completed in #16, validating the rollback later applied to HEAD.

Jan - Feb 2022

2 commits
ci: windows: run tests under timeout.
3 Feb 2022Andres Freundmaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1Also in: Windows crash / abort handling (written from the discussion, no matching patch)
Revert "graceful shutdown" changes for Windows, in back branches only.
25 Jan 2022Tom LaneREL_14_STABLE14.2REL_13_STABLE13.6REL_12_STABLE12.10REL_11_STABLE11.15REL_10_STABLE10.20revert
LLM analysis, 100% surewritten from the discussion, no matching patch3 of 3 reviewers saw the final version

645c9457f2 removes the Windows graceful-shutdown calls from src/backend/libpq/pqcomm.c for stable branches, following the rollback request in #34 and branch-scope agreement in #37 and #38. No attached patchset contains this rollback.

  • Alexander Lakhinsaw the final versionLLM analysis, 97% sureAlexander reproduced the graceful-close failure and verified that removing shutdown and closesocket made repeated postgres_fdw disconnection tests complete in #16.
  • Andres Freundsaw the final versionLLM analysis, 99% sureAndres requested reverting the changes before the upcoming minor release in #34, which Tom accepted in #35.
  • Thomas Munrosaw the final versionLLM analysis, 99% sureThomas proposed limiting the immediate rollback to release branches in #37, and Tom accepted that scope in #38.

Credits across 3 commits

Committer
Tom Lane2
Andres Freund1