Use MaxLockMode in lock methods initialization

Started by Julien Rouhaudover 4 years ago3 messageshackers
Jump to latest
#1Julien Rouhaud
rjuju123@gmail.com

Hi,

While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
but didn't update the lock methods initialization. It shouldn't make much
difference in the long run but some consistency seems better to me.

Attachments:

0001-Use-MaxLockMode-in-LockMethodData-initialization.patchtext/plain; charset=us-asciiDownload+2-3
#2Michael Paquier
michael@paquier.xyz
In reply to: Julien Rouhaud (#1)
Re: Use MaxLockMode in lock methods initialization

On Mon, Jan 03, 2022 at 02:47:22PM +0800, Julien Rouhaud wrote:

While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
but didn't update the lock methods initialization. It shouldn't make much
difference in the long run but some consistency seems better to me.

Makes sense to me. MaxLockMode is here for the same purpose as this
initialization area.
--
Michael

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Michael Paquier (#2)
Re: Use MaxLockMode in lock methods initialization

Michael Paquier <michael@paquier.xyz> writes:

On Mon, Jan 03, 2022 at 02:47:22PM +0800, Julien Rouhaud wrote:

While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
but didn't update the lock methods initialization. It shouldn't make much
difference in the long run but some consistency seems better to me.

Makes sense to me. MaxLockMode is here for the same purpose as this
initialization area.

Agreed. That aspect of b04aeb0a053e7 was a bit of a quick hack,
and it didn't occur to me to look for other places where the symbol
could be used. But these two places are spot-on for it.

Pushed with a bit of comment-fiddling.

regards, tom lane