Use MaxLockMode in lock methods initialization
Hi,
While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
but didn't update the lock methods initialization. It shouldn't make much
difference in the long run but some consistency seems better to me.
Attachments:
0001-Use-MaxLockMode-in-LockMethodData-initialization.patchtext/plain; charset=us-asciiDownload
From 1a3de43f4ed75466413ffcd884678332960c2520 Mon Sep 17 00:00:00 2001
From: Julien Rouhaud <julien.rouhaud@free.fr>
Date: Mon, 3 Jan 2022 12:19:11 +0800
Subject: [PATCH] Use MaxLockMode in LockMethodData initialization.
Commit b04aeb0a053e7 added a MaxLockMode to hold the highest lock mode so let's
use it here too.
---
src/backend/storage/lmgr/lock.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/storage/lmgr/lock.c b/src/backend/storage/lmgr/lock.c
index c25af7fe09..2e985df5af 100644
--- a/src/backend/storage/lmgr/lock.c
+++ b/src/backend/storage/lmgr/lock.c
@@ -124,7 +124,7 @@ static bool Dummy_trace = false;
#endif
static const LockMethodData default_lockmethod = {
- AccessExclusiveLock, /* highest valid lock mode number */
+ MaxLockMode, /* highest valid lock mode number */
LockConflicts,
lock_mode_names,
#ifdef LOCK_DEBUG
@@ -135,7 +135,7 @@ static const LockMethodData default_lockmethod = {
};
static const LockMethodData user_lockmethod = {
- AccessExclusiveLock, /* highest valid lock mode number */
+ MaxLockMode, /* highest valid lock mode number */
LockConflicts,
lock_mode_names,
#ifdef LOCK_DEBUG
--
2.33.1
On Mon, Jan 03, 2022 at 02:47:22PM +0800, Julien Rouhaud wrote:
While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
but didn't update the lock methods initialization. It shouldn't make much
difference in the long run but some consistency seems better to me.
Makes sense to me. MaxLockMode is here for the same purpose as this
initialization area.
--
Michael
Michael Paquier <michael@paquier.xyz> writes:
On Mon, Jan 03, 2022 at 02:47:22PM +0800, Julien Rouhaud wrote:
While reading some code around I noticed that b04aeb0a053e7 added a MaxLockMode
but didn't update the lock methods initialization. It shouldn't make much
difference in the long run but some consistency seems better to me.
Makes sense to me. MaxLockMode is here for the same purpose as this
initialization area.
Agreed. That aspect of b04aeb0a053e7 was a bit of a quick hack,
and it didn't occur to me to look for other places where the symbol
could be used. But these two places are spot-on for it.
Pushed with a bit of comment-fiddling.
regards, tom lane