Remove extra spaces

Started by Suraj Kharageover 4 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

appliessuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t45321
psql -h localhost -U postgres

Built from patchset v1 (message #1), September 20, 2026 at 11:37 AM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t45321_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t45321_1 && git checkout t45321_1

Patchset v1 (message #1) is on t45321_1

Jump to latest
#1Suraj Kharage
suraj.kharage@enterprisedb.com

Hi,

While browsing the code, noticed the extra spaces after the function name.
Removed the same in the attached patch.

--
--

Thanks & Regards,
Suraj kharage,

edbpostgres.com

Attachments:

t45321_1
remove_space_from_numeric_function.patchapplication/octet-stream; name=remove_space_from_numeric_function.patchDownload+1-1
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Suraj Kharage (#1)
Re: Remove extra spaces

Suraj Kharage <suraj.kharage@enterprisedb.com> writes:

While browsing the code, noticed the extra spaces after the function name.
Removed the same in the attached patch.

I'm afraid that's a waste of time because the next pgindent run
will just put them back. "numeric" is also a typedef name and
this usage of it seems to confuse pgindent. If you wanted to
dive into the pgindent code and fix that bug in it, that'd be
great, but the return-on-effort is probably going to be poor.

(Another possibility is to change the C function name.)

regards, tom lane