fix libpq comment
Started by Euler Taveiraabout 4 years ago2 messages
Hi,
While checking the PQping code I noticed that pg_ctl does not rely on PQping
since commit f13ea95f9e4 (v10) so the attached patch removes a comment from
internal_ping().
--
Euler Taveira
EDB https://www.enterprisedb.com/
Attachments:
0001-pg_ctl-does-not-rely-on-PQping-anymore.patchtext/x-patch; name=0001-pg_ctl-does-not-rely-on-PQping-anymore.patchDownload
From 3055de48fe71f47df357114c7a42db05edcdb290 Mon Sep 17 00:00:00 2001
From: Euler Taveira <euler.taveira@enterprisedb.com>
Date: Thu, 6 Jan 2022 20:50:30 -0300
Subject: [PATCH] pg_ctl does not rely on PQping anymore
Since commit f13ea95f9e4, PQping is not used by pg_ctl.
---
src/interfaces/libpq/fe-connect.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/interfaces/libpq/fe-connect.c b/src/interfaces/libpq/fe-connect.c
index 9b6a6939f0..dfebfd1096 100644
--- a/src/interfaces/libpq/fe-connect.c
+++ b/src/interfaces/libpq/fe-connect.c
@@ -3919,8 +3919,7 @@ internal_ping(PGconn *conn)
return PQPING_NO_RESPONSE;
/*
- * Report PQPING_REJECT if server says it's not accepting connections. (We
- * distinguish this case mainly for the convenience of pg_ctl.)
+ * Report PQPING_REJECT if server says it's not accepting connections.
*/
if (strcmp(conn->last_sqlstate, ERRCODE_CANNOT_CONNECT_NOW) == 0)
return PQPING_REJECT;
--
2.20.1
Re: fix libpq comment
On Thu, Jan 06, 2022 at 09:33:07PM -0300, Euler Taveira wrote:
While checking the PQping code I noticed that pg_ctl does not rely on PQping
since commit f13ea95f9e4 (v10) so the attached patch removes a comment from
internal_ping().
Looking at the area, the rest looks fine. So, applied as per your
suggestion. Thanks, Euler!
--
Michael