Fix a possible typo in rewriteheap.c code comments
Started by Bharath Rupireddyabout 4 years ago3 messages
Hi,
It looks like there's a typo, attaching a tiny patch to fix it.
*
* When doing logical decoding - which relies on using cmin/cmax of catalog
* tuples, via xl_heap_new_cid records - heap rewrites have to log enough
- * information to allow the decoding backend to updates its internal mapping
+ * information to allow the decoding backend to update its internal mappingRegards,
Bharath Rupireddy.
Attachments:
v1-0001-Fix-a-typo-in-rewriteheap.c-code-comments.patchapplication/x-patch; name=v1-0001-Fix-a-typo-in-rewriteheap.c-code-comments.patchDownload
From 7954f128efbda9e95cf0cc2e38588430c9ab4359 Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Mon, 10 Jan 2022 04:06:58 +0000
Subject: [PATCH v1] Fix a typo in rewriteheap.c code comments
---
src/backend/access/heap/rewriteheap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/access/heap/rewriteheap.c b/src/backend/access/heap/rewriteheap.c
index 5bb5ebba23..aa265edf60 100644
--- a/src/backend/access/heap/rewriteheap.c
+++ b/src/backend/access/heap/rewriteheap.c
@@ -741,7 +741,7 @@ raw_heap_insert(RewriteState state, HeapTuple tup)
*
* When doing logical decoding - which relies on using cmin/cmax of catalog
* tuples, via xl_heap_new_cid records - heap rewrites have to log enough
- * information to allow the decoding backend to updates its internal mapping
+ * information to allow the decoding backend to update its internal mapping
* of (relfilenode,ctid) => (cmin, cmax) to be correct for the rewritten heap.
*
* For that, every time we find a tuple that's been modified in a catalog
--
2.25.1
Re: Fix a possible typo in rewriteheap.c code comments
On Mon, Jan 10, 2022 at 9:42 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
Hi,
It looks like there's a typo, attaching a tiny patch to fix it.
* * When doing logical decoding - which relies on using cmin/cmax of catalog * tuples, via xl_heap_new_cid records - heap rewrites have to log enough - * information to allow the decoding backend to updates its internal mapping + * information to allow the decoding backend to update its internal mapping
LGTM.
--
With Regards,
Amit Kapila.
Re: Fix a possible typo in rewriteheap.c code comments
On Mon, Jan 10, 2022 at 10:22 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Mon, Jan 10, 2022 at 9:42 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:Hi,
It looks like there's a typo, attaching a tiny patch to fix it.
* * When doing logical decoding - which relies on using cmin/cmax of catalog * tuples, via xl_heap_new_cid records - heap rewrites have to log enough - * information to allow the decoding backend to updates its internal mapping + * information to allow the decoding backend to update its internal mappingLGTM.
Pushed.
--
With Regards,
Amit Kapila.