Dec 2024

1 commit
postgres_fdw: re-issue cancel requests a few times if necessary.
23 Dec 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17.3
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1421 of 1 reviewer saw the final version

Retains the retry algorithm in #142, renames RE_CANCEL_TIMEOUT and related variables, and lowers the query_cancel test timeout from 100ms to 10ms with explanatory comments.

  • Jelte Fennema-Niosaw the final versionLLM analysis, 100% sureEndorsed the retry approach and proposed the accepted RETRY naming in #143, then withdrew his helper-placement suggestion in #145.

Aug 2024

1 commit
Make postgres_fdw's query_cancel test less flaky.
30 Aug 2024Tom Lanemaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17rc1
LLM analysis, 99% suremodified before commitmoderate changesfrom patchset #1221 of 2 reviewers saw the final version

Reworks the test component of #122 for the separate query_cancel files: it self-joins ft1 instead of relocating the test, retains 100ms, and adds a preliminary remote query; #134 explains these changes.

  • Alexander Lakhinsaw an earlier versionLLM analysis, 88% sureInvestigated the landed postgres_fdw test originating in #96 and identified extra remote queries in #118, prompting the eventual avoidance of remote estimates.
  • Tom Lanesaw the final versioncommittercommitted the patch

Jul 2024

1 commit
postgres_fdw: Split out the query_cancel test to its own file
22 Jul 2024Alvaro Herreramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 100% suremodified before commitlight changesfrom patchset #1251 of 1 reviewer saw the final version

Implements the test split in #125, removes the accidentally included expected/query_cancel.sql file, and replaces the forced-Cygwin expression with the actual version check.

  • Alexander Lakhinsaw the final versionLLM analysis, 88% sureReproduced and traced the hang in the landed cancellation code from #96 to Cygwin poll behavior in #123, leading to the limited test-skip correction.

Jul 2024

1 commit
Fix copy-paste mistake in PQcancelCreate
1 Jul 2024Alvaro Herreramaster18beta1REL_19_STABLE18beta1REL_18_STABLE18beta1REL_17_STABLE17beta3
LLM analysis, 100% surelanded as postedfrom patchset #1212 of 2 reviewers saw the final version

Exactly matches the one-line component in #121 that assigns CONNECTION_BAD to cancelConn rather than the original conn in PQcancelCreate's OOM path.

  • Noah Mischsaw the final versionLLM analysis, 97% sureIdentified the wrong status-assignment target in the landed implementation from #81 and supplied the exact correction in #120.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch

Mar - Apr 2024

10 commits
Make libpqsrv_cancel's return const char *, not char *
5 Apr 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #1132 of 2 reviewers saw the final version

Matches all four const-qualification replacements in #113, covering libpqsrv_cancel, its error variable, and the dblink and postgres_fdw callers.

  • Tom Lanesaw the final versionLLM analysis, 98% sureRan C++ headerscheck against the landed helper from #96 and proposed the accepted const char * correction in #112.
  • Jelte Fennema-Niosaw the final versionLLM analysis, 100% sureExplicitly approved the attached const-correctness patch in #114.
Stabilize postgres_fdw test
30 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surewritten from the discussion, no matching patch3 of 3 reviewers saw the final version

Implements Jelte's inline BEGIN/SET LOCAL proposal in #104, using COMMIT to end the aborted transaction; no attached patch supplies this change.

  • Tom Lanesaw the final versionLLM analysis, 94% sureReviewed the inline test approach and challenged its timing-dependent coverage in #107 and #109.
  • Noah Mischsaw the final versionLLM analysis, 98% sureDefended retaining the simple SQL test and explained why probabilistic coverage was useful before commitment in #111.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
libpq-be-fe-helpers.h: wrap new cancel APIs
28 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #961 of 3 reviewers saw the final version

Uses Álvaro's forwarded revision of Jelte's helper, but removes static prverror tracking and documents transient-context allocation, as agreed in #97 and #98.

  • Noah Mischsaw an earlier versionLLM analysis, 100% sureReviewed the postgres_fdw migration and proposed the shared libpqsrv_cancel helper adopted in the subsequent redesign in #94.
  • Denis Laxaldesaw an earlier versionLLM analysis, 93% sureCorrected migration call sites in #44 and endorsed the earlier implementation in #46, before the shared helper and error-handling redesign.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
dblink/isolationtester/fe_utils: Use new cancel API
18 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #901 of 2 reviewers saw the final version

Takes the dblink, fe_utils, and isolationtester hunks from the caller-migration component of #90, leaving postgres_fdw and its regression test for #93.

  • Denis Laxaldesaw an earlier versionLLM analysis, 97% sureSupplied concrete fixes for these three callers in #44 and endorsed the resulting series in #46, before later API and cleanup changes.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
Put libpq_pipeline cancel test back
18 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 99% suremodified before commitsignificant changesfrom patchset #900 of 2 reviewers saw the final version

Restores the test as proposed in #90, but replaces its simple-query workaround with extended-query execution synchronized on the PgSleep wait event; the commit message explicitly explains Álvaro's alternative.

  • Jacob Championsaw an earlier versionLLM analysis, 100% sureReproduced failure even with the idle-wait fix and identified the Bind/Execute cancellation window in #89.
  • Tom Lanesaw an earlier versionLLM analysis, 92% sureReported additional failures of the landed test and questioned its cancellation timing in #86, before the synchronization redesign.
Hopefully make libpq_pipeline's new cancel test more reliable
13 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #871 of 2 reviewers saw the final version

Preserves the idle-before-active synchronization from #87, but reworks wait_for_connection_state to take a PID, constructs parameters outside the loop, and changes allocation and diagnostics.

  • Tom Lanesaw an earlier versionLLM analysis, 93% sureReported intermittent failures and analyzed the timing assumption in #86, before the helper refactoring and added idle-state wait.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
libpq: Add encrypted and non-blocking query cancellation routines
12 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #812 of 2 reviewers saw the final version

Matches the final API implementation in #81 with extensive SGML wording, indexing, cross-reference, and formatting edits plus minor source cleanup, consistent with #82.

  • Denis Laxaldesaw the final versiontrailerTested the API through Psycopg, proposed reusable cancellation objects, supplied fixups, and rechecked the near-final API in #72, after which the API changes were naming and cleanup.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
libpq: Move pg_cancel to fe-cancel.c
12 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #761 of 1 reviewer saw the final version

Matches the pg_cancel relocation component in #76, with revised comments describing the backing structure, backend PID, and cancellation key.

  • Alvaro Herrerasaw the final versioncommittercommitted the patch
Add tests for libpq query cancellation APIs
11 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitmoderate changesfrom patchset #761 of 3 reviewers saw the final version

Starts from the standalone legacy-cancellation tests in #76, but monitors by backend PID instead of query text and adds copy_connection using PQconninfo and PQconnectdbParams.

  • Jacob Championsaw an earlier versionLLM analysis, 96% sureRan the cancellation tests with required GSS encryption and requested test output improvements in #4, before monitoring and connection-copy changes.
  • Denis Laxaldesaw an earlier versionLLM analysis, 91% sureTested the series and reviewed cancellation-test reuse in #40 and #42, before the committed test's PID-based monitoring rework.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
Add missing connection statuses to docs
11 Mar 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #762 of 2 reviewers saw the final version

Matches the connection-status documentation component of #76, with additional punctuation and capitalization cleanup in libpq-fe.h comments.

  • Denis Laxaldesaw the final versionLLM analysis, 92% sureFlagged the missing connection-state list in #72, prompting the documentation audit and separate correction described in #73.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch

Jan - Feb 2024

4 commits
libpq: Change some static functions to extern
4 Feb 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #651 of 1 reviewer saw the final version

Matches the internal-function export component in #65 except that the premature pqCopyPGconn declaration is omitted from libpq-int.h.

  • Alvaro Herrerasaw the final versioncommittercommitted the patch
libpq: Add pqReleaseConnHosts function
4 Feb 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% surelanded as postedfrom patchset #652 of 2 reviewers saw the final version

Matches the pqReleaseConnHosts extraction component in #65; the only observed difference is wrapping the explicit_bzero call.

  • Denis Laxaldesaw the final versionLLM analysis, 82% sureReviewed and tested the earlier cancellation implementation containing this host-release helper in #40 and #46, before its extraction and naming cleanup.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch
libpq: Move cancellation related functions to fe-cancel.c
29 Jan 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #611 of 1 reviewer saw the final version

Matches the fe-cancel.c extraction component in #61, with pq_parse_int_param renamed pqParseIntParam and relocated within fe-connect.c, as reported in #62.

  • Alvaro Herrerasaw the final versioncommittercommitted the patch
Make spelling of cancelled/cancellation consistent
26 Jan 2024Alvaro Herreramaster17beta1REL_19_STABLE17beta1REL_18_STABLE17beta1REL_17_STABLE17beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #542 of 2 reviewers saw the final version

Uses the spelling-cleanup component of #54 and adds another canceled spelling correction in a test comment.

  • Thomas Munrosaw the final versionLLM analysis, 99% sureIdentified inconsistent cancellation spellings in #50, directly prompting the separate cleanup patch.
  • Alvaro Herrerasaw the final versioncommittercommitted the patch

Sep 2022

1 commit
Doc: add some doco about using the libpq_pipeline test module.
14 Sep 2022Tom Lanemaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #171 of 1 reviewer saw the final version

Expands and rewrites the README component last submitted in #17, adding server-selection and test-discovery instructions and correcting trace-command ordering; #20 confirms the wordsmithing.

  • Tom Lanesaw the final versioncommittercommitted the patch

Credits across 19 commits

Author
Jelte Fennema-Nio3 LLM15
Alvaro HerreraLLM3
Tom LaneLLM1
Reviewer
Alvaro Herreracommitter13
Tom Lanecommitter2
Denis Laxalde1
Reported by
Alexander Lakhin1
Noah Misch1
Thomas Munro1
Committer
Alvaro Herrera16
Tom Lane3

N LLM means N of the credits come from LLM analysis, not from commit trailers.