Consistently use the function name CreateCheckPoint instead of CreateCheckpoint in code comments
Hi,
The function CreateCheckPoint is specified as CreateCheckpoint in some
of the code comments whereas in other places it is correctly
mentioned. Attaching a tiny patch to use CreateCheckPoint consistently
across code comments.
Regards,
Bharath Rupireddy.
Attachments:
v1-0001-Consistently-use-the-function-name-CreateCheckPoi.patchapplication/octet-stream; name=v1-0001-Consistently-use-the-function-name-CreateCheckPoi.patchDownload
From 77e6252a2ceb3312710c68b21a1c83a5bda30150 Mon Sep 17 00:00:00 2001
From: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Date: Fri, 14 Jan 2022 02:32:49 +0000
Subject: [PATCH v1] Consistently use the function name CreateCheckPoint
instead of CreateCheckpoint in code comments
---
src/backend/storage/buffer/bufmgr.c | 2 +-
src/backend/storage/ipc/standby.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c
index 4b72274989..a2512e750c 100644
--- a/src/backend/storage/buffer/bufmgr.c
+++ b/src/backend/storage/buffer/bufmgr.c
@@ -3907,7 +3907,7 @@ MarkBufferDirtyHint(Buffer buffer, bool buffer_std)
* never gets written, so crash recovery will fix.
*
* It's possible we may enter here without an xid, so it is
- * essential that CreateCheckpoint waits for virtual transactions
+ * essential that CreateCheckPoint waits for virtual transactions
* rather than full transactionids.
*/
MyProc->delayChkpt = delayChkpt = true;
diff --git a/src/backend/storage/ipc/standby.c b/src/backend/storage/ipc/standby.c
index d70f2e839d..87ac0f74b2 100644
--- a/src/backend/storage/ipc/standby.c
+++ b/src/backend/storage/ipc/standby.c
@@ -1182,7 +1182,7 @@ standby_redo(XLogReaderState *record)
* starting to accumulate changes at a point just prior to when we derive
* the snapshot on the primary, then ignore duplicates when we later apply
* the snapshot from the running xacts record. This is implemented during
- * CreateCheckpoint() where we use the logical checkpoint location as
+ * CreateCheckPoint() where we use the logical checkpoint location as
* our starting point and then write the running xacts record immediately
* before writing the main checkpoint WAL record. Since we always start
* up from a checkpoint and are immediately at our starting point, we
--
2.25.1
On Thu, Jan 13, 2022 at 10:25 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
Hi,
The function CreateCheckPoint is specified as CreateCheckpoint in some
of the code comments whereas in other places it is correctly
mentioned. Attaching a tiny patch to use CreateCheckPoint consistently
across code comments.
Heh, that's interesting, as I would have said that CreateCheckpoint is
the right casing vs CreateCheckPoint, but it looks like it has always
been the other way (according to
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=f0e37a85319e6c113ecd3303cddeb6edd5a6ac44).
Robert Treat
https://xzilla.net
On Fri, Jan 14, 2022 at 8:55 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
The function CreateCheckPoint is specified as CreateCheckpoint in some
of the code comments whereas in other places it is correctly
mentioned. Attaching a tiny patch to use CreateCheckPoint consistently
across code comments.
LGTM. I'll take care of this unless someone thinks otherwise.
--
With Regards,
Amit Kapila.
On Fri, Jan 14, 2022 at 8:05 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
On Fri, Jan 14, 2022 at 8:55 AM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:The function CreateCheckPoint is specified as CreateCheckpoint in some
of the code comments whereas in other places it is correctly
mentioned. Attaching a tiny patch to use CreateCheckPoint consistently
across code comments.LGTM. I'll take care of this unless someone thinks otherwise.
Pushed.
--
With Regards,
Amit Kapila.