model-writtenrun 7339 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Daniel Gustafsson submitted a patch credited to Jacob Champion that required connect_ok() to produce no stderr, explaining that this check had exposed NSS bugs and quirks and would benefit other libraries too; the patch also adjusted callers' test counts #1.
- Álvaro Herrera suggested grouping connect_ok() assertions into a subtest to simplify future additions, while Tom Lane endorsed the stderr check and abandoning explicit test counting #2 #3.
- Daniel supplied a revision that grouped some assertions into a subtest to avoid changing callers, but preferred the original patch's readability; Álvaro clarified that he intended all assertions to be grouped, accepting an initial caller adjustment #4 #5.
- Dagfinn Ilmari Mannsåker advocated converting scripts to done_testing() whenever counts changed, Andrew Dunstan suggested doing so whenever scripts were edited, and Álvaro supported conversion without making it mandatory; Michael Paquier also welcomed the direction #6 #7 #8 #9.
- Michael Paquier endorsed the stderr-checking change and reported that its code paths appeared covered #10.
- Daniel committed the original patch's Cluster.pm changes as 4d373e0528, leaving out the subtest alternative and the now-unnecessary caller test-plan adjustments; his final message confirmed the work was applied #11.