Unnecessary call to resetPQExpBuffer in getIndexes

Started by Julien Rouhaudabout 4 years ago4 messageshackers

rjuju123@gmail.com

about 4 years ago

Hi,

I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer()
which seems unnecessary since the variable is untouched since the initial
createPQExpBuffer().

Simple patch attached.

Nathan Bossart

nathandbossart@gmail.com

about 4 years ago

In reply to: Julien Rouhaud (#1)

Re: Unnecessary call to resetPQExpBuffer in getIndexes

On Wed, Feb 09, 2022 at 10:50:07AM +0800, Julien Rouhaud wrote:

I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer()
which seems unnecessary since the variable is untouched since the initial
createPQExpBuffer().

Simple patch attached.

LGTM

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

Peter Eisentraut

peter_e@gmx.net

about 4 years ago

In reply to: Nathan Bossart (#2)

Re: Unnecessary call to resetPQExpBuffer in getIndexes

On 09.02.22 19:21, Nathan Bossart wrote:

On Wed, Feb 09, 2022 at 10:50:07AM +0800, Julien Rouhaud wrote:

I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer()
which seems unnecessary since the variable is untouched since the initial
createPQExpBuffer().

Simple patch attached.

LGTM

committed

Julien Rouhaud

rjuju123@gmail.com

about 4 years ago

In reply to: Peter Eisentraut (#3)

Re: Unnecessary call to resetPQExpBuffer in getIndexes

On Thu, Feb 10, 2022 at 12:25:36PM +0100, Peter Eisentraut wrote:

On 09.02.22 19:21, Nathan Bossart wrote:

On Wed, Feb 09, 2022 at 10:50:07AM +0800, Julien Rouhaud wrote:

I just noticed that e2c52beecd (adding PeterE in Cc) added a resetPQExpBuffer()
which seems unnecessary since the variable is untouched since the initial
createPQExpBuffer().

Simple patch attached.

LGTM

committed

Thanks!

Unnecessary call to resetPQExpBuffer in getIndexes

Attachments: