Feb 2022

2 commits
Remove command checks in tests of pg_basebackup and pg_receivewal
15 Feb 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #122 of 2 reviewers saw the final version

The commit implements all three --version removals in src/bin/pg_basebackup/t/010_pg_basebackup.pl and 020_pg_receivewal.pl from #12, differing only in whitespace.

  • Andres Freundsaw the final versionLLM analysis, 99% sureAndres argued against executing commands merely to check availability in #4, a suggestion explicitly adopted in #12 and credited by the commit's Reported-by trailer.
  • Tom Lanesaw the final versionLLM analysis, 88% sureTom said the combined patch #8 looked OK in #9, and its cleanup portion subsequently gained only the analogous pg_basebackup test change.
Add ./configure check for "lz4" command
14 Feb 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #83 of 3 reviewers saw the final version

The commit takes the configure, configure.ac and src/Makefile.global.in changes from #8, deferring its pg_receivewal cleanup. It also adds empty-string decompressor guards to pg_verifybackup's 008_untar.pl and 010_client_untar.pl, as explained in #12.

  • Tom Lanesaw the final versionLLM analysis, 99% sureTom proposed PGAC_PATH_PROGS in #7 and reviewed #8 positively while asking about MSVC support in #9.
  • Andres Freundsaw the final versionLLM analysis, 97% sureAndres identified the hardcoded LZ4 assignment and missing configure check in #5, directly establishing the defect fixed by the commit.
  • Robert Haassaw the final versionLLM analysis, 85% sureRobert argued that executable discovery belonged to configure in #3, and the commit explicitly credits the discussion with him.

Credits across 2 commits

Author
Michael PaquierLLM2
Reported by
Andres Freund1
Committer
Michael Paquier2

N LLM means N of the credits come from LLM analysis, not from commit trailers.