Feb 2022

2 commits
Avoid dangling-pointer usage in pg_basebackup progress reports.
17 Feb 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The src/bin/pg_basebackup/pg_basebackup.c changes implement the plan in #12: duplicate and free filenames centrally through progress_update_filename(), only when showprogress && verbose. The commit predates #16, whose attachment changes tests only.

  • Robert Haassaw the final versionLLM analysis, 99% sureBefore the commit, Robert recommended copying every assigned progress filename and freeing previous allocations in #11, which Tom adopted in #12.
Delete contrib/xml2's legacy implementation of xml_is_well_formed().
14 Feb 2022Tom Lanemaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch1 of 1 reviewer saw the final version

The commit removes the legacy xml_is_well_formed() implementation from contrib/xml2/xpath.c, exactly the deletion proposed in #5 and supported in #7. No attached patchset implements this change; #16 concerns pg_basebackup tests.

  • Andrew Dunstansaw the final versionLLM analysis, 98% sureAndrew explicitly supported deleting the obsolete compatibility function with a +1 in #7, before the commit.

Credits across 2 commits

Committer
Tom Lane2