doc: join state for merge join
Started by Zhihong Yualmost 4 years ago2 messages
Hi,
When i was looking at the code for ExecMergeJoin(), I noticed a few places
where the join state name in the comment doesn't match the actual state.
Here is a small patch with correction.
Cheers
Attachments:
merge-join-state-doc.patchapplication/octet-stream; name=merge-join-state-doc.patchDownload
diff --git a/src/backend/executor/nodeMergejoin.c b/src/backend/executor/nodeMergejoin.c
index a049bc4ae0..933b878caa 100644
--- a/src/backend/executor/nodeMergejoin.c
+++ b/src/backend/executor/nodeMergejoin.c
@@ -1143,7 +1143,7 @@ ExecMergeJoin(PlanState *pstate)
break;
/*----------------------------------------------------------
- * EXEC_MJ_SKIP means compare tuples and if they do not
+ * EXEC_MJ_SKIP_TEST means compare tuples and if they do not
* match, skip whichever is lesser.
*
* For example:
@@ -1199,7 +1199,7 @@ ExecMergeJoin(PlanState *pstate)
break;
/*
- * SKIPOUTER_ADVANCE: advance over an outer tuple that is
+ * EXEC_MJ_SKIPOUTER_ADVANCE: advance over an outer tuple that is
* known not to join to any inner tuple.
*
* Before advancing, we check to see if we must emit an
@@ -1261,7 +1261,7 @@ ExecMergeJoin(PlanState *pstate)
break;
/*
- * SKIPINNER_ADVANCE: advance over an inner tuple that is
+ * EXEC_MJ_SKIPINNER_ADVANCE: advance over an inner tuple that is
* known not to join to any outer tuple.
*
* Before advancing, we check to see if we must emit an
Re: doc: join state for merge join
On 19 Feb 2022, at 14:20, Zhihong Yu <zyu@yugabyte.com> wrote:
When i was looking at the code for ExecMergeJoin(), I noticed a few places where the join state name in the comment doesn't match the actual state.
Given the comments on the other states, I'm bound to agree. Unless there are
objections I'll go ahead with this one.
--
Daniel Gustafsson https://vmware.com/