show schema.collate in explain(verbose on)

Started by wangsh.fnst@fujitsu.comover 4 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t45560
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 03:13 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t45560_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t45560_1 && git checkout t45560_1

Patchset v1 (message #1) is on t45560_1

Jump to latest
#1wangsh.fnst@fujitsu.com
wangsh.fnst@fujitsu.com

Hi,

The comment of get_collation_name wrote:

* NOTE: since collation name is not unique, be wary of code that uses this
* for anything except preparing error messages.

In file explain.c, the function get_collation_name() is called, but the schema
name won't be outputted.

Since the schema name of relation/function name will be outputted in
explain's result when verbose(on) is specified. I plan to output the schema
name of collation as well as relation/function.

The patch attached, any thought?

Regards
Shenhao Wang

Attachments:

t45560_1
0001-show-schema-name-of-collation-in-explain-verbose.patchapplication/octet-stream; name=0001-show-schema-name-of-collation-in-explain-verbose.patchDownload+52-12
#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: wangsh.fnst@fujitsu.com (#1)
Re: show schema.collate in explain(verbose on)

"wangsh.fnst@fujitsu.com" <wangsh.fnst@fujitsu.com> writes:

Since the schema name of relation/function name will be outputted in
explain's result when verbose(on) is specified. I plan to output the schema
name of collation as well as relation/function.

While that's not unreasonable in principle, it seems like it'll just be
useless verbosity in pretty much any actual database. In what scenario
would you have duplicate collation names?

regards, tom lane