Oct - Nov 2022

12 commits
Add TAP tests for include directives in HBA end ident files
28 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #921 of 1 reviewer saw the final version

Commits only the positive cases from #92 in src/test/authentication/t/004_file_inclusion.pl, rewriting counter handling and comparing basenames instead of normalized full paths. #95 explicitly describes the split and supplies the uncommitted negative tests.

  • Michael Paquiersaw the final versiontrailerReviewed test structure and portability, then rewrote and committed the positive cases as explained in #95.
Introduce variables for initial and max nesting depth on configuration files
24 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #871 of 1 reviewer saw the final version

Takes the depth-constant component of #87, leaving its TAP-test component pending. Differences are comment additions and formatting, confirmed in #88.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Add support for file inclusions in HBA and ident configuration files
24 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #831 of 1 reviewer saw the final version

Takes the inclusion feature from #83 without its TAP tests, renames tokenize_inclusion_file() to tokenize_include_file(), polishes documentation and comments, and bumps catversion. The attachment and commit credit Julien Rouhaud despite Michael Paquier posting the series.

  • Michael Paquiersaw the final versiontrailerReviewed inclusion ordering, error semantics, memory management, and documentation, then polished and committed the feature in #85.
Add missing initialization in tokenize_expand_file() for output list
24 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #831 of 1 reviewer saw the final version

The exact inc_lines = NIL initialization is attached in the inclusion component of #83, having first appeared in Michael Paquier's changes in #82. It was committed separately after being omitted from the memory-context split.

  • Julien Rouhaudsaw the final versionLLM analysis, 87% sureReviewed Michael Paquier's revised tokenization work and said the patch looked good in #84, before this initialization was committed.
Rework memory contexts in charge of HBA/ident tokenization
23 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #831 of 1 reviewer saw the final version

Commits the memory-context prerequisite from #83, leaving inclusion separate. Changes to hba.c are principally comments and declaration placement; Julien's suggested clarification from 'loading' to 'opening' is included.

  • Julien Rouhaudsaw the final versiontrailerApproved the revised memory-context design and requested a clearer lifecycle comment in #84.
Add error context callback when tokenizing authentication files
14 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #731 of 1 reviewer saw the final version

Takes the ErrorContextCallback component of #73, with the additional tokenize_error_callback_arg entry in src/tools/pgindent/typedefs.list. The hba.c implementation otherwise matches.

  • Julien Rouhaudsaw the final versiontrailerSaid the callback patch looked good and agreed that filenames and line numbers supplied sufficient diagnostics in #74.
Invent open_auth_file() in hba.c to refactor authentication file opening
14 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #73

Commits the open_auth_file() component last posted in #73, with comment punctuation and whitespace adjustments. The commit credits Michael Paquier and Julien Rouhaud as co-authors.

Use AbsoluteConfigLocation() when building an included path in hba.c
8 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 98% surepart of a posted patchsetmoderate changesfrom patchset #70

Takes AbsoluteConfigLocation() reuse from #70 but omits that version's dynamically sized result buffer, retaining MAXPGPATH with a narrower declaration scope in conffiles.c. #71 identifies this as the landed prerequisite.

Move code related to configuration files in directories to new file
7 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #66

Extracts the combined conffiles.c/conffiles.h and directory-enumeration changes from both attachments in #66, leaving authentication changes pending. Applying those attachments and comparing the resulting utility files shows only comments, formatting, and an unnecessary include removed; both developers receive author credit.

doc: Fix some descriptions related to pg_ident_file_mappings
2 Nov 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15.1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #571 of 1 reviewer saw the final version

Extracts two rule-to-map terminology corrections from the inclusion patch in #57, adjusting doc/src/sgml/system-views.sgml independently of file inclusion. #66 explicitly reports this extraction and its backpatch.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Add rule_number to pg_hba_file_rules and map_number to pg_ident_file_mappings
26 Oct 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 99% surepart of a posted patchsetlight changesfrom patchset #572 of 2 reviewers saw the final version

Takes the numbering component of #57, rebasing away its rejected fill-function prerequisite, renaming mapping_number to map_number, polishing documentation, and bumping catversion. #59 confirms the numbering patch landed while the prototype simplification was discarded.

  • Aleksander Alekseevsaw the final versionLLM analysis, 88% sureReviewed and tested the inclusion patch containing this same numbering logic in #14; its later extraction and naming changes preserve that behavior.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Refactor code handling the names of files loaded in hba.c
26 Oct 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #541 of 2 reviewers saw the final version

Extracts source-file tracking from #54, omits IdentLine.sourcefile, and adds two auth.c reporting changes using HbaLine.sourcefile. It predates #57, so that later attachment cannot be its source; the commit credits Julien Rouhaud.

  • Aleksander Alekseevsaw an earlier versionLLM analysis, 84% sureReviewed and tested the earlier inclusion patch's file tracking and diagnostics in #14, before the later extraction and auth.c reporting changes.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Jul - Aug 2022

3 commits
Make consistent a couple of log messages when parsing HBA files
5 Aug 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #431 of 1 reviewer saw the final version

Combines the two ident error-message patches from #43: regex failures gain file/line context and missing-field diagnostics move location details into errcontext(). #46 explicitly confirms the merge.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Use hba_file/ident_file GUCs rather than pg_hba.conf/pg_ident.conf in logs
5 Aug 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #431 of 1 reviewer saw the final version

Commits only the real-filename logging component of #43; its patch ID matches exactly. The changes replace hardcoded authentication filenames in postmaster.c and postinit.c.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Fix path reference when parsing pg_ident.conf for pg_ident_file_mappings
26 Jul 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta3
LLM analysis, 100% surelanded as postedfrom patchset #411 of 1 reviewer saw the final version

The standalone patch in #41 has the same stable patch ID as the commit: fill_ident_view() passes IdentFileName to tokenize_auth_file().

  • Michael Paquiersaw the final versioncommittercommitted the patch

Mar 2022

3 commits
Add system view pg_ident_file_mappings
29 Mar 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #282 of 2 reviewers saw the final version

Takes the mapping-view portion of #28 after separately extracting its existing-HBA-view regression query. Remaining edits correct documentation links and comments, adjust formatting, and bump catversion, as described in #29.

  • Aleksander Alekseevsaw the final versiontrailerReviewed the mapping view and ran installcheck-world in #14 and #15, with only light corrections and test changes following.
  • Michael Paquiersaw the final versiontrailerReviewed parser exposure, view columns, tests, and error reporting, then applied cosmetic corrections and committed the view in #29.
Modify query on pg_hba_file_rules to check for errors in regression tests
29 Mar 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #281 of 1 reviewer saw the final version

Extracts the pg_hba_file_rules error-count query and expected output from the mapping-view patch in #28, with explanatory comments. #29 explicitly says this independent test change was split out first.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Refactor code related to pg_hba_file_rules() into new file
24 Mar 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surelanded as postedfrom patchset #172 of 2 reviewers saw the final version

The standalone hbafuncs.c extraction posted by Michael Paquier in #17 has an identical stable patch ID. The attachment and commit attribute the patch to Julien Rouhaud.

  • Aleksander Alekseevsaw the final versiontrailerSaid the extraction looked good in #14, before only naming and comment changes in #17.
  • Michael Paquiersaw the final versiontrailerRequested a history-preserving extraction, supplied final naming changes in #17, and announced its commit in #20.

Credits across 18 commits

Author
Julien Rouhaud14
Michael Paquier2 LLM6
based on an idea from me1
Reviewer
Michael Paquiercommitter12
Aleksander Alekseev2
Julien Rouhaud2
Committer
Michael Paquier18

N LLM means N of the credits come from LLM analysis, not from commit trailers.