Aug 2022

2 commits
Remove initialization of MyClientConnectionInfo at backend startup
24 Aug 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

Deletes only the MyClientConnectionInfo memset in src/backend/postmaster/postmaster.c; no attachment proposes this deletion. Jacob questioned its necessity in #86, Tom agreed in #88, and the commit explicitly credits both objections.

  • Jacob Championsaw the final versionLLM analysis, 99% sureQuestioned why static initialization was insufficient for the memset introduced in #84, directly motivating the cleanup in #86.
  • Tom Lanesaw the final versionLLM analysis, 99% sureConfirmed in #88 that static initialization also works under EXEC_BACKEND and identified the added memset as useless and confusing.
Allow parallel workers to retrieve some data from Port
24 Aug 2022Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #843 of 5 reviewers saw the final version

Matches all seven files of #84, preserving the authentication and serialization implementation; the substantive textual difference relocates the redundant memset from InitProcessGlobals() to BackendInitialize(), as explained in #87. The commit credits Jacob Champion, whose preceding implementation is attached to #80.

  • Bertrand Drouvotsaw the final versiontrailerRequested auth_method in #74, reported successful integration tests and a missing struct tag in #76, reviewed serialization in #81, and approved the final posting in #85.
  • Stephen Frostsaw an earlier versiontrailerFound the early SQL patch reasonable in #15 and supported inheriting the leader's identity in #18, before the global structure and serialization implementation were added.
  • Robert Haassaw an earlier versiontrailerQuestioned copying overhead in #36 and shaped the ClientConnectionInfo name and semantic scope in #52 and #60, before auth_method and the final serialization format were added.
  • Tom Lanesaw the final versiontrailerAdvocated separating authentication data from Port in #30 and #32, discussed naming and GUC drawbacks, and reviewed the landed initialization in #88, prompting its removal.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 2 commits

Author
Jacob Champion1
Reviewer
Bertrand Drouvot1
Michael Paquiercommitter1
Robert Haas1
Stephen Frost1
Tom Lane1
Committer
Michael Paquier2