Feb 2023

3 commits
Add LZ4 compression to pg_dump
23 Feb 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 94% surepart of a posted patchsetsignificant changesfrom patchset #261 of 5 reviewers saw the final version

Lands the LZ4 component of #26, retaining its LZ4File buffering and streaming implementation but moving it into compress_lz4.{c,h} behind callbacks. It also adopts pg_compress_specification, USE_LZ4, an older-library header-size fallback, and revised tests; the final revision is not attached in the supplied thread.

  • Michael Paquiersaw an earlier versiontrailerRequested per-method files and callback interfaces in #2 and reiterated the design in #8, before the substantial implementation rework.
  • Rachel Heatonsaw an earlier versiontrailerCross-platform testing and debugging assistance are credited in #1, and she supplied the assisted revision in #6, before the callback conversion.
  • Justin Pryzbysaw an earlier versiontrailerQuestioned high-compression support in #3 and identified old-library compatibility, conditional-compilation, and implementation issues in #10 and #11.
  • Shi Yuno review foundtrailerThe commit credits Shi Yu, but the supplied thread contains no review activity by this person.
  • Tomas Vondrasaw the final versiontrailerNo review message appears in the supplied thread, but Tomas Vondra committed the final version.
Introduce a generic pg_dump compression API
23 Feb 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 87% surepart of a posted patchsetsignificant changesfrom patchset #261 of 4 reviewers saw the final version

Reworks the compression abstraction and archive-header portions of #26 into callback-based CompressorState and CompressFileHandle APIs with separate compress_gzip and compress_none files. The archive format stores the algorithm instead of retaining both level and method, and the callback implementation requested in #2 is absent from the attached revisions.

  • Michael Paquiersaw an earlier versiontrailerProposed the callback architecture and separate implementation files in #2 and #8, but no review of the final implementation appears here.
  • Rachel Heatonsaw an earlier versiontrailerProvided testing and debugging assistance credited in #1 and helped produce #6, before the generic API was substantially redesigned.
  • Justin Pryzbysaw an earlier versiontrailerReviewed the original series and advocated separate method implementations, shared compression specifications, and simpler file-opening logic in #10.
  • Tomas Vondrasaw the final versiontrailerNo review message appears in the supplied thread, but Tomas Vondra committed the final version.
Prepare pg_dump internals for additional compression methods
23 Feb 2023Tomas Vondramaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 95% surepart of a posted patchsetmoderate changesfrom patchset #261 of 4 reviewers saw the final version

Extracts the cfp conversion from the preparatory patch in #26: cfopen_internal/cfdopen, removal of OutputContext and GZ macros, and conversion of archive output operations. The committed subset uses pg_compress_specification and a new supports_compression helper rather than the attachment's method/level arguments and inline checks.

  • Michael Paquiersaw an earlier versiontrailerReviewed the compression refactoring direction in #2 and #8, before the committed subset acquired its revised specification and support checks.
  • Rachel Heatonsaw an earlier versiontrailerHelped test the original series as credited in #1 and assisted the revision posted in #6, before the later implementation changes.
  • Justin Pryzbysaw an earlier versiontrailerExplicitly recommended separating the pg_backup_archiver.c cfp conversion and simplifying cfopen_write in #10.
  • Tomas Vondrasaw the final versiontrailerNo review message appears in the supplied thread, but Tomas Vondra committed the final version.

Mar - Apr 2022

3 commits
Extend TAP tests of pg_dump to test for compression with gzip
5 Apr 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #271 of 1 reviewer saw the final version

Matches the complete gzip-test attachment in #27, with only Perl formatting and revised wording in the compile_option comment. Although Michael Paquier posted that revision, the commit credits Georgios Kokolatos and Rachel Heaton as authors, consistent with #1 and #6.

  • Michael Paquiersaw the final versioncommittercommitted the patch
Clean up some dead code in pg_dump with tar format and gzip compression
31 Mar 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #242 of 2 reviewers saw the final version

The pg_backup_tar.c diff matches the complete tar-cleanup component of the four-patch series in #24, including its added _StartBlob() check. Michael Paquier confirms applying that component in #25; the other series components are excluded.

  • Justin Pryzbysaw the final versionLLM analysis, 90% sureSupported the dead-code conclusion using the attached test, documentation, and prior tar-compression investigation in #9, with only a small additional cleanup following.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Add TAP test in pg_dump with --format=tar and --compress
30 Mar 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #202 of 2 reviewers saw the final version

Extracts only the tar/compression checks in src/bin/pg_dump/t/001_basic.pl from #20. The committed test adds -j3 to force failure without zlib, adds an explanatory comment, and shortens the test label; #22 confirms the separate application.

  • Justin Pryzbysaw the final versionLLM analysis, 88% sureExamined and cited the attached tar/compression rejection test as evidence of unsupported behavior in #9, before the lightly adjusted extraction landed.
  • Michael Paquiersaw the final versioncommittercommitted the patch

Credits across 6 commits

Author
Georgios Kokolatos6
Rachel Heaton3
Reviewer
Michael Paquiercommitter6
Justin Pryzby3
Rachel Heaton3
Tomas Vondra3
Shi Yu1
Committer
Michael Paquier3
Tomas Vondra3