Fix a typo in pg_receivewal.c's get_destination_dir()

Started by Bharath Rupireddyabout 4 years ago2 messageshackers
Jump to latest
#1Bharath Rupireddy
bharath.rupireddyforpostgres@gmail.com

Hi,

It looks like there's a typo in pg_receivewal.c's
get_destination_dir(), that is, use the function parameter dest_folder
instead of global variable basedir in the error message. Although
there's no harm in it as basedir is a global variable in
pg_receivewal.c, let's use the function parameter to be in sync with
close_destination_dir.

Attaching a tiny patch to fix it.

Regards,
Bharath Rupireddy.

Attachments:

v1-0001-Fix-a-typo-in-pg_receivewal.c-s-get_destination_d.patchapplication/octet-stream; name=v1-0001-Fix-a-typo-in-pg_receivewal.c-s-get_destination_d.patchDownload+1-2
#2Andres Freund
andres@anarazel.de
In reply to: Bharath Rupireddy (#1)
Re: Fix a typo in pg_receivewal.c's get_destination_dir()

Hi,

On 2022-02-26 22:04:13 +0530, Bharath Rupireddy wrote:

It looks like there's a typo in pg_receivewal.c's
get_destination_dir(), that is, use the function parameter dest_folder
instead of global variable basedir in the error message. Although
there's no harm in it as basedir is a global variable in
pg_receivewal.c, let's use the function parameter to be in sync with
close_destination_dir.

Attaching a tiny patch to fix it.

Good catch, pushed.

Greetings,

Andres Freund