Jul 2022

2 commits
Remove unnecessary Windows-specific basebackup code.
22 Jul 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta3
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #331 of 1 reviewer saw the final version

Takes the second patch of #33, removing the Windows-specific branch in xlog.c and adding the in-place tablespace backup test. Apart from rebasing, the test reuses $backupdir instead of redeclaring it.

  • Michael Paquiersaw the final versiontrailerIn #34, he endorsed the follow-up series and discussed its backup coverage; only light changes followed.
Fix get_dirent_type() for Windows junction points.
22 Jul 2022Thomas Munromaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1REL_15_STABLE15beta3REL_14_STABLE14.5Also in: standby recovery fails (tablespace related) (tentative patch and discussion) (not this thread)
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #331 of 2 reviewers saw the final version

Takes the first patch of #33, reordering the attribute checks in src/port/dirent.c with only an expanded explanatory comment. The supplied verdict for thread #40458 confirms that it discussed this existing fix without a matching attachment, so attribution remains with this thread.

  • Michael Paquiersaw the final versiontrailerIn #34, he examined the reordered attribute checks and explicitly confirmed that they also handled plain files correctly.
  • Alvaro Herrerano review foundtrailerHis only contribution here is a post-commit thank-you in #36, while #35 and the supplied verdict for thread #40458 place his pre-commit involvement in that other thread.

Mar 2022

3 commits
doc: Remove mention to in-place tablespaces for pg_tablespace_location()
18 Mar 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% surewritten from the discussion, no matching patch2 of 2 reviewers saw the final version

Removes the newly added pg_tablespace_location() paragraph from doc/src/sgml/func.sgml, implementing Thomas Munro's proposal in #28 and the agreement in #29 and #30. No attachment proposes this deletion.

  • Thomas Munrosaw the final versionLLM analysis, 100% sureIn #28, he proposed removing the paragraph because developer-only details confused the general documentation and the existing description remained accurate.
  • Kyotaro Horiguchisaw the final versionLLM analysis, 100% sureIn #30, he explicitly agreed to dropping the paragraph before the documentation rollback was committed.
Fix pg_tablespace_location() with in-place tablespaces
17 Mar 2022Michael Paquiermaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #231 of 2 reviewers saw the final version

The misc.c implementation and both regression-test changes match #23. Only doc/src/sgml/func.sgml is shortened and reworded following #24, as the committer explains in #25.

  • Kyotaro Horiguchisaw the final versiontrailerHe discussed the original path semantics in #2, then reviewed the documentation and reported successful Rocky8 and Windows11 tests of the revised patch in #24.
  • Thomas Munrosaw an earlier versiontrailerHe proposed an alternative implementation in #16 and accepted relative-path semantics in #19 and #21, before the implementation restructuring in #23.
Fix pg_basebackup with in-place tablespaces.
15 Mar 2022Thomas Munromaster15beta1REL_19_STABLE15beta1REL_18_STABLE15beta1REL_17_STABLE15beta1REL_16_STABLE15beta1REL_15_STABLE15beta1
LLM analysis, 100% suremodified before commitlight changesfrom patchset #112 of 2 reviewers saw the final version

Preserves the complete xlog.c logic from #11, changing only the comment from producing spurious warnings to failing below. This reflects the Windows failure demonstrated in #13.

  • Kyotaro Horiguchisaw the final versiontrailerHe reported the initial fix working in #8 and confirmed the revised patch on CentOS8 and Windows11 in #13, identifying the unpatched Windows failure.
  • Michael Paquiersaw the final versiontrailerHe identified the Windows junction problem and proposed the platform-specific checks in #10, then approved the revised patch in #14.

Credits across 5 commits

Author
Thomas MunroLLM3
Michael Paquier1
Reviewer
Michael Paquier3
Kyotaro Horiguchi2
Alvaro Herrera1
Thomas Munro1
Reported by
Kyotaro Horiguchi1
Committer
Thomas Munro3
Michael Paquier2

N LLM means N of the credits come from LLM analysis, not from commit trailers.