Mar 2023

4 commits
libpq: Add sslcertmode option to control client certificates
24 Mar 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #591 of 4 reviewers saw the final version

Commits the sslcertmode portion of #59, leaving the SASL refinement uncommitted and extracting the sslmode wording hunk separately. Remaining differences are documentation, comments, formatting, test descriptions and parameterized error wording, consistent with the application report in #60.

  • Aleksander Alekseevsaw an earlier versiontrailerRequested certificate documentation and comment fixes in #36 and reported passing tests in #44, before the later sslcertmode memory-cleanup fix.
  • Peter Eisentrautsaw an earlier versiontrailerApproved the general direction and identified the missing Meson certificate callback check in #33, before later lifecycle cleanup and test additions.
  • David G. Johnstonno review foundtrailerHis contribution in #16 concerns require_auth alternatives and channel-binding interactions; no review of the separate sslcertmode patch is visible in this thread.
  • Michael Paquiersaw the final versioncommittercommitted the patch
Rewrite error message related to sslmode in libpq
24 Mar 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #591 of 1 reviewer saw the final version

Exactly extracts the fe-connect.c hunk in #59 that replaces literal sslmode in the no-SSL error format with a parameter. Michael requested this translation-saving change in #58, and the commit message explicitly identifies extraction from Jacob's larger patch.

  • Michael Paquiersaw the final versioncommittercommitted the patch
libpq: Add support for require_auth to control authorized auth methods
14 Mar 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetlight changesfrom patchset #551 of 3 reviewers saw the final version

Matches the require_auth patch in #55, including creds handling, connection-state cleanup and the new SSPI test suite, with only comment wrapping and Kerberos test-description edits. The certificate and SASL patches were left for follow-up, as confirmed in #56.

  • Peter Eisentrautsaw an earlier versiontrailerReviewed naming and compatibility in #24, accepted the SCRAM/GSS semantics in #31, and requested translation fixes in #33, before creds support and connection-state changes.
  • David G. Johnstonsaw an earlier versiontrailerChallenged OR and fallback semantics and asked that existing channel-binding behavior remain intact in #16, before negation, none and subsequent implementation revisions.
  • Michael Paquiersaw the final versiontrailerProposed list support, reviewed correctness and cleanup, supplied #51, requested final tests in #53, and committed #55 after the review reported in #56.
Run pgindent on libpq's fe-auth.c, fe-auth-scram.c and fe-connect.c
9 Mar 2023Michael Paquiermaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surewritten from the discussion, no matching patch

Preparatory pgindent cleanup of fe-auth.c, fe-auth-scram.c and fe-connect.c has no matching attachment; git show -w produces no changes. Its commit message explicitly ties the cleanup to easing Jacob's pending work, and #51 subsequently discusses pgindent issues during that review.

Credits across 4 commits

Author
Jacob Champion3
Reviewer
Michael Paquiercommitter3
David G. Johnston2
Peter Eisentraut2
Aleksander Alekseev1
Committer
Michael Paquier4