Comment typo in CheckCmdReplicaIdentity
PSA patch to fix a comment typo.
(The 'OR' should not be uppercase - that keyword is irrelevant here).
------
Kind Regards,
Peter Smith.
Fujitsu Australia
Attachments:
v1-0001-Fix-comment-typo-CheckCmdReplicaIdentity.patchapplication/octet-stream; name=v1-0001-Fix-comment-typo-CheckCmdReplicaIdentity.patchDownload
From b646f4500eb31743600df6f69181211584f5f16d Mon Sep 17 00:00:00 2001
From: Peter Smith <peter.b.smith@fujitsu.com>
Date: Mon, 7 Mar 2022 09:15:14 +1100
Subject: [PATCH v1] Fix comment typo CheckCmdReplicaIdentity
---
src/backend/executor/execReplication.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/backend/executor/execReplication.c b/src/backend/executor/execReplication.c
index de106d7..09f78f2 100644
--- a/src/backend/executor/execReplication.c
+++ b/src/backend/executor/execReplication.c
@@ -607,7 +607,7 @@ CheckCmdReplicaIdentity(Relation rel, CmdType cmd)
return;
/*
- * This is either UPDATE OR DELETE and there is no replica identity.
+ * This is UPDATE/DELETE and there is no replica identity.
*
* Check if the table publishes UPDATES or DELETES.
*/
--
1.8.3.1
On Mon, Mar 07, 2022 at 09:31:33AM +1100, Peter Smith wrote:
PSA patch to fix a comment typo.
(The 'OR' should not be uppercase - that keyword is irrelevant here).
I was looking at the whole routine, and your suggestion looks like an
improvement to me. Will apply if there are no objections.
--
Michael
On Mon, Mar 07, 2022 at 10:36:24AM +0900, Michael Paquier wrote:
On Mon, Mar 07, 2022 at 09:31:33AM +1100, Peter Smith wrote:
PSA patch to fix a comment typo.
(The 'OR' should not be uppercase - that keyword is irrelevant here).
I was looking at the whole routine, and your suggestion looks like an
improvement to me. Will apply if there are no objections.
+1
On Mon, Mar 07, 2022 at 10:28:08AM +0800, Julien Rouhaud wrote:
+1
And done.
--
Michael