[PATCH] Double declaration in pg_upgrade.h

Started by Pavel Borisovover 4 years ago2 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

won't retrysuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t45643
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 27, 2026 at 03:12 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t45643_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t45643_1 && git checkout t45643_1

Patchset v1 (message #1) is on t45643_1

Jump to latest
#1Pavel Borisov
pashkin.elfe@gmail.com

Hi, hackers!
I've noticed that check_ok() in pg_upgrade.h has been declared two times.
Here's a one-line patch correcting this.

--
Best regards,
Pavel Borisov

Postgres Professional: http://postgrespro.com <http://www.postgrespro.com&gt;

Attachments:

t45643_1
v1-0001-Fix-double-declaration-for-check_ok-in-pg_upgrade.patchapplication/octet-stream; name=v1-0001-Fix-double-declaration-for-check_ok-in-pg_upgrade.patchDownload+0-2
#2Peter Eisentraut
peter_e@gmx.net
In reply to: Pavel Borisov (#1)
Re: [PATCH] Double declaration in pg_upgrade.h

On 09.03.22 11:29, Pavel Borisov wrote:

I've noticed that check_ok() in pg_upgrade.h has been declared two times.
Here's a one-line patch correcting this.

Fixed, thanks.