Oct 2022

1 commit
Create subscription stats entry at CREATE SUBSCRIPTION time
7 Oct 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surelanded as postedfrom patchset #241 of 2 reviewers saw the final version

The complete diff matches #24 after normalizing index hashes and hunk locations, including pgstat_create_subscription() and both regression-test files. Andres announced the push in #30.

  • Andres Freundsaw the final versiontrailerAndres requested tests in #18, simplified initialization in #20, improved test isolation and repeated-reset coverage in #22, and committed the final version after #29.
  • Amit Kapilasaw an earlier versiontrailerAmit questioned the need to change the original behavior in #9 and discussed shared-memory semantics in #12, before the implementation rewrite; his later response in #27 concerned backpatch policy.

Jul 2022

2 commits
pgstat: drop subscription stats without slot as well, fix comment
6 Jul 2022Andres Freundmaster16beta1REL_19_STABLE16beta1REL_18_STABLE16beta1REL_17_STABLE16beta1REL_16_STABLE16beta1
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #172 of 2 reviewers saw the final version

Exactly matches the deletion-fix attachment in #17, making pgstat_drop_subscription(subid) unconditional and removing the obsolete autovacuum comment in src/backend/commands/subscriptioncmds.c. It omits the submission's separate statistics-creation patch.

  • Amit Kapilasaw the final versionLLM analysis, 92% sureAmit endorsed unconditional statistics deletion and confirmed that autovacuum no longer performs cleanup in #12, reviewing the inline proposal in #11 before its attachment.
  • Andres Freundsaw the final versioncommittercommitted the patch
pgstat: drop subscription stats regardless of slot, fix comment
6 Jul 2022Andres FreundREL_15_STABLE15beta3
LLM analysis, 100% surepart of a posted patchsetmoderate changesfrom patchset #172 of 2 reviewers saw the final version

Matches the deletion-fix attachment in #17 modulo hunk location and index hashes, including the unconditional pgstat_drop_subscription() call and shortened comment. It contains none of the separate statistics-creation attachment.

  • Amit Kapilasaw the final versionLLM analysis, 92% sureAmit endorsed unconditional statistics deletion and confirmed that autovacuum no longer performs cleanup in #12, reviewing the inline proposal in #11 before its attachment.
  • Andres Freundsaw the final versioncommittercommitted the patch

Credits across 3 commits

Author
Masahiko Sawada3
Reviewer
Andres Freundcommitter3
Amit Kapila1
Committer
Andres Freund3