model-writtenrun 7226 - may be wrong, links go to the source messages. Commit-by-commit LLM analysis is in the Commits dialog.
- Andres Freund reported that ICU headers produced roughly 30,000 lines of cpluspluscheck errors because C++ declarations appeared inside extern "C", and considered limiting diagnostics, skipping problematic headers, or removing ICU headers from PostgreSQL headers #1.
- Andres submitted a CI patch that disabled ICU for these checks and capped error output, and Thomas Munro approved it #2 #3.
- Andrew Dunstan pointed out that the workaround left manual and buildfarm users exposed; Andres agreed a proper fix was needed but argued that CI coverage should proceed, and the attached patch landed unchanged as 81b9f23c9c #4 #5.
- Nearly a year later, Andres proposed suppressing ICU draft APIs, then corrected his testing: only defining U_SHOW_CPLUSPLUS_API to zero worked, leaving a choice between a supposedly internal macro and awkward manipulation of extern "C" blocks #6 #7.
- Andres subsequently found ICU documentation supporting the macro approach, and Peter Eisentraut endorsed it while suggesting undefining the macro afterward to avoid interfering with extensions; the supplied thread ends with this proposal supported but no attached implementation #8 #9.
- The implementation subsequently landed in July 2025 as ed26c4e25a from John Naylor’s matching patchset #594815 in thread #51836, which owns the commit attribution; it suppresses ICU C++ APIs, removes the CI workaround, and leaves the macro defined while documenting that extensions needing ICU C++ APIs can include ICU headers first.