Invalid comment in ParallelQueryMain

Started by Julien Rouhaudalmost 4 years ago4 messages
#1Julien Rouhaud
rjuju123@gmail.com
1 attachment(s)

Hi,

While reading code around I just noticed that I failed to adapt a comment a
couple of lines above a removed line in 0f61727b75b9. Patch attached.

Attachments:

v1-0001-Fix-comment-in-ParallelQueryMain.patchtext/plain; charset=us-asciiDownload
From 5ba34dd1129cd1e2038ac70992a6b5e77df6121e Mon Sep 17 00:00:00 2001
From: Julien Rouhaud <julien.rouhaud@free.fr>
Date: Sat, 26 Mar 2022 23:55:59 +0800
Subject: [PATCH v1] Fix comment in ParallelQueryMain

Oversight in 0f61727b75b93915ca9a9f20c996ed7020996a38.

Backpatch to 14.
---
 src/backend/executor/execParallel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/executor/execParallel.c b/src/backend/executor/execParallel.c
index 5dd8ab7db2..9a0d5d59ef 100644
--- a/src/backend/executor/execParallel.c
+++ b/src/backend/executor/execParallel.c
@@ -1420,7 +1420,7 @@ ParallelQueryMain(dsm_segment *seg, shm_toc *toc)
 	/* Setting debug_query_string for individual workers */
 	debug_query_string = queryDesc->sourceText;
 
-	/* Report workers' query and queryId for monitoring purposes */
+	/* Report workers' query for monitoring purposes */
 	pgstat_report_activity(STATE_RUNNING, debug_query_string);
 
 	/* Attach to the dynamic shared memory area. */
-- 
2.33.1

#2Matthias van de Meent
boekewurm+postgres@gmail.com
In reply to: Julien Rouhaud (#1)
Re: Invalid comment in ParallelQueryMain

On Sat, 26 Mar 2022 at 17:01, Julien Rouhaud <rjuju123@gmail.com> wrote:

Hi,

While reading code around I just noticed that I failed to adapt a comment a
couple of lines above a removed line in 0f61727b75b9. Patch attached.

+1, seems OK to me.

#3Michael Paquier
michael@paquier.xyz
In reply to: Matthias van de Meent (#2)
Re: Invalid comment in ParallelQueryMain

On Sat, Mar 26, 2022 at 05:12:05PM +0100, Matthias van de Meent wrote:

On Sat, 26 Mar 2022 at 17:01, Julien Rouhaud <rjuju123@gmail.com> wrote:

While reading code around I just noticed that I failed to adapt a comment a
couple of lines above a removed line in 0f61727b75b9. Patch attached.

+1, seems OK to me.

Yep. Will fix.
--
Michael

#4Julien Rouhaud
rjuju123@gmail.com
In reply to: Michael Paquier (#3)
Re: Invalid comment in ParallelQueryMain

Hi,

On Sun, Mar 27, 2022 at 04:13:00PM +0900, Michael Paquier wrote:

On Sat, Mar 26, 2022 at 05:12:05PM +0100, Matthias van de Meent wrote:

On Sat, 26 Mar 2022 at 17:01, Julien Rouhaud <rjuju123@gmail.com> wrote:

While reading code around I just noticed that I failed to adapt a comment a
couple of lines above a removed line in 0f61727b75b9. Patch attached.

+1, seems OK to me.

Yep. Will fix.

For the archive's sake, this has been pushed as-of
411b91360f2711e36782b68cd0c9bc6de44d3384.

Thanks!